[betalabs] MentorDashboard: "TypeError: log is not a function" error when clicking on info icon
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	Apr 28 2023, 11:33 PM

Project Tags

Referenced Files

	F36968830: Screen Shot 2023-04-28 at 3.45.19 PM.png
	Apr 28 2023, 11:33 PM

Subscribers

Description

Steps:

On betalabs go to Special:MentorDashboard
In "Send praise" module click on the info buttons - the Console error will be produced on opening and closing the info popup.

Screen Shot 2023-04-28 at 3.45.19 PM.png (1,210×740 px, 114 KB)

TypeError: log is not a function
    at onOpen (eval at Fp (load.php?lang=en&modules=ext.growthExperiments.MentorDashboard%2Cicons%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%2Cvue%2Cvuex%7Cmediawiki.language.names%7Cmediawiki.widgets.UserInputWidget%7Coojs-ui.styles.icons-editing-core%2Cicons-interactions%2Cicons-moderation%2Cicons-movement%2Cicons-user&skin=vector&version=3wapo:665:801), <anonymous>:53:28)

TypeError: log is not a function
    at onClose (eval at Fp (load.php?lang=en&modules=ext.growthExperiments.MentorDashboard%2Cicons%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%2Cvue%2Cvuex%7Cmediawiki.language.names%7Cmediawiki.widgets.UserInputWidget%7Coojs-ui.styles.icons-editing-core%2Cicons-interactions%2Cicons-moderation%2Cicons-movement%2Cicons-user&skin=vector&version=3wapo:665:801), <anonymous>:96:29)

Note:

the error is present in Vector 2022 and Vector legacy
the error is present with opened/hidden side menus

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	CScoreCards: Move logging responsibility upper in the stack	Urbanecm	mediawiki/extensions/GrowthExperiments	master	+15 -10

Customize query in gerrit

Event Timeline

Etonkovidova created this task.Apr 28 2023, 11:33 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptApr 28 2023, 11:33 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Maintenance_bot added a project: GrowthExperiments-Mentorship.Apr 28 2023, 11:46 PM

Change 913967 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] CScoreCards: Move logging responsibility upper in the stack

https://gerrit.wikimedia.org/r/913967

gerritbot added a project: Patch-For-Review.May 1 2023, 5:33 PM

Thanks @Etonkovidova for filling this task. The issue is caused by no frontend instrumentation present in the Mentor dashboard and as such, by the log function being undefined. This didn't break anything (the events which called the non-existent log functions were analytics-only, serving no user-visible feature), but we should fix the console error regardless. Uploaded a patch that moves the logging responsibility away from the shared component (namely, to NewImpact.vue, where the existence of the log function can be safely assumed). Moving to Code Review.

Note: When verifying this task, it would be helpful to ensure the instrumentation itself continues to work (opening and closing the tooltips should be visible in event logging data), as the proposed fix touches this area of code.

Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.May 1 2023, 5:37 PM

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.May 4 2023, 9:47 AM

Change 913967 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] CScoreCards: Move logging responsibility upper in the stack

https://gerrit.wikimedia.org/r/913967

Maintenance_bot removed a project: Patch-For-Review.May 4 2023, 10:10 AM

Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.May 4 2023, 10:04 PM