| BrandonXLF | |
| Apr 29 2023, 6:21 PM |
| F36994637: Screenshot 2023-05-12 at 2.09.18 PM.png | |
| May 12 2023, 9:10 PM |
| F36976299: Screenshot 2023-05-04 at 9.02.10 PM.png | |
| May 5 2023, 4:04 AM |
| F36969627: image.png | |
| Apr 29 2023, 6:21 PM |
Right now indicators do not have any margin whereas siteSub has 8px of margin above it.
This causes indicators to be right below the toolbar without any space. It would be better to apply the margin that siteSub has to indicators as well. Even if the siteSub is hidden this margin should still be shown.
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T335627#8828732 |
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T335627#8848532 |
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| Apply margin-top to indicators | BrandonXLF | mediawiki/skins/Vector | master | +11 -2 |
Change 913637 had a related patch set uploaded (by BrandonXLF; author: BrandonXLF):
[mediawiki/skins/Vector@master] Apply margin-top to indicators
Thank you for bringing this to the Web team's attention. I did some digging into this bug and it looks like it was introduced in this patch : Work around browser inconsistencies with 'clear' + 'margin-top'. Previous to that patch, the top margin of the #siteSub element was pushing down the indicators as well. Afterwards it wasn't, and I'm not really sure why. Regardless, adding the same margin to indicators independently seems like a more robust solution.
Change 913637 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Apply margin-top to indicators
Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Artifact(s):
✅ AC1: Use consistent margin for siteSub and indicators
Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Artifact(s):
✅ AC1: Use consistent margin for siteSub and indicators
