Page MenuHomePhabricator

Flex attribute on prp-index-pagelist element adds undesirable line breaks
Open, Needs TriagePublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

Other information (browser name/version, screenshots, etc.):
Removing the CSS flex attribute on the prp-index-pagelist style solves the problem.

That attribute was added, if I'm correct, by T277267.

Event Timeline

I don't think removing the flex is the way to go. We could possibly wrap empty numbering with some kind of container instead of having them as strings.

Also I don't think page numbers marked empty are supposed to be displayed at all, the fact that they are being displayed at all is a bug.

The documentation says: "empty: the current numeral is kept, but the hyperlink to the page is removed, thus appearing as plain text" (https://wikisource.org/wiki/Wikisource:ProofreadPage#The_%3Cpagelist/%3E_tag)

Therefore I suppose that the fact that they are displayed is intentional.

We could possibly wrap empty numbering with some kind of container instead of having them as strings.

I confirm that wrapping each "empty" number with <span class="prp-index-pagelist-page">...</span> solves the problem.