Page MenuHomePhabricator
Create Task
Maniphest T335648

Fullscreen map is blank if opened twice
Closed, ResolvedPublicBUG REPORT
Actions

Description

Maps can't be opened twice. The issue affects all projects (it was checked for Wikipedia, Wikidata, and Wikivoyage).

How to reproduce:

  • Click on maplink/mapframe to open a full-screen map
  • Exit full-screen mode
  • Click on maplink/mapframe again
  • There is an empty white background instead of a map

Details

Other Assignee
thiemowmde
SubjectRepoBranchLines +/-
Remove bogus map offset calculation in fullscreen modemediawiki/extensions/Kartographermaster+1 -20
Remove bogus fullscreen map footer offset calculationmediawiki/extensions/Kartographermaster+1 -2
Reset offset when map dialog is closedmediawiki/extensions/Kartographermaster+10 -6
Fix clearing wrong container when closing fullscreen mapmediawiki/extensions/Kartographerwmf/1.41.0-wmf.7+2 -2
Fix clearing wrong container when closing fullscreen mapmediawiki/extensions/Kartographerwmf/1.41.0-wmf.6+2 -2
Fix clearing wrong container when closing fullscreen mapmediawiki/extensions/Kartographermaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

putnik created this task.Apr 30 2023, 7:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 30 2023, 7:57 PM
Jack_who_built_the_house subscribed.Apr 30 2023, 7:59 PM
stjn added a project: Regression.Apr 30 2023, 8:35 PM
Galobtter subscribed.May 1 2023, 12:50 AM
SoThisIsPeter subscribed.EditedMay 1 2023, 1:38 AM

A very basic fix I found by messing in devtools is simply to reload all the kartographer modules after exiting from full screen. e.g:

reg_keys = keys(mw.loader.moduleRegistry)
for (i=0; i<reg_keys.length; i++) {
    if (reg_keys[i].includes("ext.kartographer")) {
        mw.loader.moduleRegistry[reg_keys[i]].script = undefined
        mw.loader.moduleRegistry[reg_keys[i]].state = "registered"
        mw.loader.load(reg_keys[i])
    }
}

Edit: After further investigation, all that need be reloaded is ext.kartographer.dialog:

mw.loader.moduleRegistry["ext.kartographer.dialog"].script = undefined
mw.loader.moduleRegistry["ext.kartographer.dialog"].state = "registered"
mw.loader.load("ext.kartographer.dialog")
gerritbot added a comment.May 1 2023, 2:46 AM

Change 913690 had a related patch set uploaded (by SoThisIsPeter; author: SoThisIsPeter):

[mediawiki/extensions/Kartographer@master] Reload dialog module on dialog close - T335648

https://gerrit.wikimedia.org/r/913690

gerritbot added a project: Patch-For-Review.May 1 2023, 2:46 AM
Galobtter triaged this task as Unbreak Now! priority.May 2 2023, 1:03 AM

Boldly triaging as unbreak now since this half totally breaks maps functionality.

Pikne added subscribers: WMDE-Fisch, Pikne.May 2 2023, 6:24 AM

It looks this issue is there since 1.41/wmf.6 branch. Does it relate to T333160?

WMDE-Fisch added a project: WMDE-TechWish-Sprint-2023-04-19.May 2 2023, 8:29 AM
WMDE-Fisch updated Other Assignee, added: thiemowmde.
WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2023-04-19 board.
gerritbot added a comment.May 2 2023, 8:54 AM

Change 914266 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Fix clearing wrong container when closing fullscreen map

https://gerrit.wikimedia.org/r/914266

gerritbot added a comment.May 2 2023, 8:55 AM

Change 913690 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Kartographer@master] Reload dialog module on dialog close - T335648

Reason:

I785f52e fixes the actual cause of this bug.

https://gerrit.wikimedia.org/r/913690

thiemowmde moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2023-04-19 board.May 2 2023, 8:57 AM
thiemowmde edited projects, added Maps (Kartographer), WMDE-GeoInfo-FocusArea; removed Maps.
thiemowmde lowered the priority of this task from Unbreak Now! to Needs Triage.May 2 2023, 9:04 AM
thiemowmde subscribed.

Thanks a lot for digging into this. Very much appreciated! However. The issue got unnoticed for about a week because most people open a map only a single time. Let's not make it sound more dramatic than it is.

gerritbot added a comment.May 2 2023, 10:10 AM

Change 914286 had a related patch set uploaded (by WMDE-Fisch; author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@wmf/1.41.0-wmf.6] Fix clearing wrong container when closing fullscreen map

https://gerrit.wikimedia.org/r/914286

gerritbot added a comment.May 2 2023, 10:10 AM

Change 914287 had a related patch set uploaded (by WMDE-Fisch; author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@wmf/1.41.0-wmf.7] Fix clearing wrong container when closing fullscreen map

https://gerrit.wikimedia.org/r/914287

gerritbot added a comment.May 2 2023, 10:14 AM

Change 914278 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Remove bogus fullscreen map footer offset calculation

https://gerrit.wikimedia.org/r/914278

gerritbot added a comment.May 2 2023, 10:14 AM

Change 914279 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Remove bogus map offset calculation in fullscreen mode

https://gerrit.wikimedia.org/r/914279

gerritbot added a comment.May 2 2023, 10:27 AM

Change 914266 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Fix clearing wrong container when closing fullscreen map

https://gerrit.wikimedia.org/r/914266

gerritbot added a comment.May 2 2023, 1:20 PM

Change 914286 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@wmf/1.41.0-wmf.6] Fix clearing wrong container when closing fullscreen map

https://gerrit.wikimedia.org/r/914286

gerritbot added a comment.May 2 2023, 1:20 PM

Change 914287 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@wmf/1.41.0-wmf.7] Fix clearing wrong container when closing fullscreen map

https://gerrit.wikimedia.org/r/914287

Stashbot mentioned this in T333137: Test and enable mobile support for the nearby feature.May 2 2023, 1:22 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-02T13:22:40Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:914267|Enable Kartographer Nearby on mobile (T333137)]], [[gerrit:914286|Fix clearing wrong container when closing fullscreen map (T335648)]], [[gerrit:914287|Fix clearing wrong container when closing fullscreen map (T335648)]]

Stashbot added a comment.May 2 2023, 1:24 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-02T13:24:03Z] <urbanecm@deploy1002> wmde-fisch and urbanecm: Backport for [[gerrit:914267|Enable Kartographer Nearby on mobile (T333137)]], [[gerrit:914286|Fix clearing wrong container when closing fullscreen map (T335648)]], [[gerrit:914287|Fix clearing wrong container when closing fullscreen map (T335648)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet

Stashbot added a comment.May 2 2023, 1:37 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-02T13:37:34Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:914267|Enable Kartographer Nearby on mobile (T333137)]], [[gerrit:914286|Fix clearing wrong container when closing fullscreen map (T335648)]], [[gerrit:914287|Fix clearing wrong container when closing fullscreen map (T335648)]] (duration: 14m 54s)

WMDE-Fisch moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2023-04-19 board.May 2 2023, 1:41 PM

Fix was just deployed to all wikis and seems to be working.

lilients_WMDE moved this task from Backlog to In sprint on the WMDE-GeoInfo-FocusArea board.May 2 2023, 1:49 PM
thiemowmde added a project: WMDE-TechWish-Sprint-2023-05-03.May 3 2023, 7:52 AM
thiemowmde moved this task from Sprint Backlog to Demo on the WMDE-TechWish-Sprint-2023-05-03 board.May 3 2023, 7:53 AM
gerritbot added a comment.May 5 2023, 6:47 AM

Change 916092 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Kartographer@master] Reset offset when map dialog is closed

https://gerrit.wikimedia.org/r/916092

gerritbot added a comment.May 12 2023, 10:28 AM

Change 919287 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Remove bogus fullscreen map footer offset calculation

https://gerrit.wikimedia.org/r/919287

gerritbot added a comment.May 12 2023, 10:46 AM

Change 914279 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Kartographer@master] Remove bogus map offset calculation in fullscreen mode

Reason:

Replaced with Icc7ad20.

https://gerrit.wikimedia.org/r/914279

gerritbot added a comment.May 12 2023, 10:47 AM

Change 914278 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Kartographer@master] Remove bogus fullscreen map footer offset calculation

Reason:

Replaced with I45a1954.

https://gerrit.wikimedia.org/r/914278

gerritbot added a comment.May 12 2023, 12:09 PM

Change 916092 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Reset offset when map dialog is closed

https://gerrit.wikimedia.org/r/916092

gerritbot added a comment.May 12 2023, 1:35 PM

Change 919328 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] [POC] Fix fullscreen map jumping on open in static mode

https://gerrit.wikimedia.org/r/919328

WMDE-Fisch removed a project: Patch-For-Review.May 12 2023, 3:36 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 16 2023, 4:01 AM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.6; 2023-04-24); removed MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 16 2023, 5:02 AM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.10; 2023-05-23); removed MW-1.41-notes (1.41.0-wmf.6; 2023-04-24).May 16 2023, 8:01 PM
lilients_WMDE moved this task from Demo to Done on the WMDE-TechWish-Sprint-2023-05-03 board.May 17 2023, 8:18 AM
Galobtter unsubscribed.May 19 2023, 8:02 AM
WMDE-Fisch closed this task as Resolved.May 24 2023, 7:17 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL