Page MenuHomePhabricator

Leaving Add Image Tags screen with added image tags not published must be prepended by a warning or a confirmation
Closed, ResolvedPublic

Description

Description

As a mobile Wikipedia app user
I want to see any warning that my work is going to be lost, if I press Back without publishing newly added image tags
So that my time is not wasted and my work is not lost

Steps to reproduce

  1. Open Wikipedia mobile app for Android
  2. Open any article having title image that hasn't got image tags added yet
  3. Tap + Add Image Tags link
  4. Add some tags
  5. (Accidentally) Press Back button in Android's main interface

Expected results

A warning is displayed that added image tags are not yet published and work is going to be lost.

Actual results

No warning is displayed. Mobile app returns to the previous screen. Added image tags are not published. Work is lost. Time is wasted.

Screenshots

Screenshot_20230501-012419.png (665×720 px, 72 KB)

Event Timeline

trejder renamed this task from Leaving Add Image Tags screen with tags not added must be prepended by a warning to Leaving Add Image Tags screen with added image tags not published must be prepended by a warning or a confirmation.May 1 2023, 10:35 AM
ABorbaWMF subscribed.

This looks good on 2.7.50446-beta-2023-06-14

I noticed a small inconsistency: It is possible to add a tag to an image and tap forward or backward (w/o publishing). If the user returns to that image after selecting backward or forward, the tag remains, and publish button is enabled. Should we also display this warning after backward or forward when the user has added a tag?

In my humble opinion -- yes. The fact that tag remains and publish button is enabled only means that user effort is not lost. But this doesn't change the fact that this particular tag or these particular tags are still not published.

Depending on what message is displayed when leaving the screen without publishing tags this could sill be in force. For example, if we are displaying: "These tags are still not published. Are you sure you want to leave?" then no matter how you are going to reach that screen (back, forward etc.), leaving it should still show the same message (because these tags are still not published and you are again leaving).

This looks good on 2.7.50446-beta-2023-06-14

I noticed a small inconsistency: It is possible to add a tag to an image and tap forward or backward (w/o publishing). If the user returns to that image after selecting backward or forward, the tag remains, and publish button is enabled. Should we also display this warning after backward or forward when the user has added a tag?

Created a new task for this: https://phabricator.wikimedia.org/T341368. So closing this one out.