Page MenuHomePhabricator

Batches are being stored for more than 14 days
Closed, ResolvedPublic5 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • query the GET /v2/barches/2023-02-22 API

What happens?:
You receive 200 status code and list of batches.

What should have happened instead?:
You should receive 404 status code and no batches (cuz we should not store batches for longer than 14 days).

Other information (browser name/version, screenshots, etc.):
The deletion job happens in snapshots service, cuz we use the same image for batches and snapshots.

Implementation notes
We can use terraform to set s3 lifecycle with filter so that we only delete objects from batches directory that are older than X days

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_lifecycle_configuration#specifying-a-filter-using-key-prefixes

Event Timeline