Page MenuHomePhabricator
Create Task
Maniphest T335714

Section-level images: finalize copy and QQQ descriptions for TranslateWiki.net
Closed, ResolvedPublic
Actions

Description

User story & summary:
  • As a newcomer, I want clear and consistent language used for the section-level "add an image" task, so that I understand the task.
  • As a translator, I want to be able to understand the context for each string that I translate, because that ensures that my translations make sense and fit the feature.

Copy doc.

Acceptance Criteria:
  • Designer to create copy doc, and add any suggestions for alternate copy to explore
  • PM to review copy, add/update QQQ, & respond to any additional comments
  • Engineers update any copy that has changed
  • Engineers Add/edit the TWN description field for TranslateWiki (Growth team)
  • Engineers Add the corresponding field name (Engineering)
  • Quality Assurance check that strings correspond to the Final copy text (QA)

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/GrowthExperimentsmaster+1 -1i18n: Fix en.json for addimage details dialog
mediawiki/extensions/GrowthExperimentsmaster+2 -2i18n: Fix en.json for image and section image recommendation task type description
mediawiki/extensions/GrowthExperimentsmaster+4 -4i18n: Onboarding dialog en.json fixes
mediawiki/extensions/GrowthExperimentsmaster+1 -1i18n: Fix en.json for time to complete section image recommendation
mediawiki/extensions/GrowthExperimentsmaster+6 -6Consistent capitalization of article names in messages
mediawiki/extensions/GrowthExperimentsmaster+1 -1i18n: Fix the text for section image header
Customize query in gerrit

Related Objects
Search...

Event Timeline

KStoller-WMF created this task.May 1 2023, 9:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 1 2023, 9:46 PM
KStoller-WMF edited projects, added Growth-Team (Current Sprint); removed Growth-Team.May 1 2023, 9:47 PM
KStoller-WMF added a parent task: T321754: [EPIC] Section-Level Images (newcomer structured task) .
KStoller-WMF moved this task from Incoming to Needs Design/Design Doing on the Growth-Team (Current Sprint) board.
KStoller-WMF moved this task from Backlog to May 15-19 (Hackathon) on the Section-Level-Image-Suggestions board.
KStoller-WMF triaged this task as High priority.May 3 2023, 7:26 PM
KStoller-WMF mentioned this in T336550: Section-Level Images: quality gate.May 16 2023, 9:55 PM
kostajh added a subscriber: kostajh.May 17 2023, 11:07 AM

Is there a document for this already?

JFernandez-WMF added a comment.May 17 2023, 2:14 PM
In T335714#8858573, @kostajh wrote:

Is there a document for this already?

Yes, there is! It's WIP though, hoping to finish it today.

KStoller-WMF claimed this task.May 18 2023, 5:16 PM
KStoller-WMF updated the task description. (Show Details)
KStoller-WMF moved this task from Needs Design/Design Doing to In Progress on the Growth-Team (Current Sprint) board.
KStoller-WMF added a subscriber: JFernandez-WMF.
Tgr mentioned this in T337900: [QA task] Section level image suggestions - testing in beta.Jun 1 2023, 5:06 PM
KStoller-WMF updated the task description. (Show Details)Jun 1 2023, 9:42 PM
KStoller-WMF removed KStoller-WMF as the assignee of this task.Jun 1 2023, 11:43 PM
KStoller-WMF moved this task from In Progress to Ready for Development on the Growth-Team (Current Sprint) board.
KStoller-WMF moved this task from May 15-19 (Hackathon) to June 5-9 on the Section-Level-Image-Suggestions board.Jun 2 2023, 4:38 PM
KStoller-WMF updated the task description. (Show Details)
KStoller-WMF added a subscriber: Sgs.Jun 2 2023, 4:44 PM

@Sgs I've reviewed the copy doc. Most copy should remain unchanged, but there are a few changes to copy which I added to the "final copy" column. I figure it's easiest to spot the changes if I leave it like that (AKA don't move all of the other unchanged copy from "proposed copy" to "final copy", but let me know if you want me to do that.

KStoller-WMF moved this task from Ready for Development to Top Product Priorities on the Growth-Team (Current Sprint) board.Jun 4 2023, 2:50 PM
JFernandez-WMF added a comment.Jun 4 2023, 11:03 PM

Noting here a discrepancy between what is in Beta and what is determined in the copy doc for visibility purposes:

On the Suggested Edits module, the header for the task type should read "Add an image to an article section" instead of "Add a suggested section image"

en.wikipedia.beta.wmflabs.org_w_index.php_title=Special_Homepage&source=personaltoolslink&namespace=0(Desktop).png (700×743 px, 36 KB)

gerritbot added a comment.Jun 5 2023, 10:42 AM

Change 927137 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] i18n: Fix the text for section image header

https://gerrit.wikimedia.org/r/927137

gerritbot added a project: Patch-For-Review.Jun 5 2023, 10:42 AM
kostajh added a comment.Jun 5 2023, 10:42 AM
In T335714#8901145, @JFernandez-WMF wrote:

Noting here a discrepancy between what is in Beta and what is determined in the copy doc for visibility purposes:

On the Suggested Edits module, the header for the task type should read "Add an image to an article section" instead of "Add a suggested section image"

en.wikipedia.beta.wmflabs.org_w_index.php_title=Special_Homepage&source=personaltoolslink&namespace=0(Desktop).png (700×743 px, 36 KB)

Thanks for catching that! Fixed in https://gerrit.wikimedia.org/r/927137

gerritbot added a comment.Jun 5 2023, 5:27 PM

Change 927137 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] i18n: Fix the text for section image header

https://gerrit.wikimedia.org/r/927137

Maintenance_bot removed a project: Patch-For-Review.Jun 5 2023, 5:30 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.12; 2023-06-06).Jun 5 2023, 7:00 PM
kostajh claimed this task.Jun 6 2023, 2:11 PM
kostajh moved this task from Top Product Priorities to In Progress on the Growth-Team (Current Sprint) board.
kostajh added a subscriber: Amire80.Jun 7 2023, 1:03 PM

@JFernandez-WMF do the proposed changes in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/927228 look OK to you? cc @Amire80

gerritbot added a comment.Jun 7 2023, 1:04 PM

Change 927228 had a related patch set uploaded (by Kosta Harlan; author: Amire80):

[mediawiki/extensions/GrowthExperiments@master] Consistent capitalization of article names in messages

https://gerrit.wikimedia.org/r/927228

gerritbot added a project: Patch-For-Review.Jun 7 2023, 1:04 PM
Tgr mentioned this in T338109: Section-level images: edit explanation for patrollers.Jun 7 2023, 11:35 PM
gerritbot added a comment.Jun 9 2023, 12:52 PM

Change 927228 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Consistent capitalization of article names in messages

https://gerrit.wikimedia.org/r/927228

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.13; 2023-06-13); removed MW-1.41-notes (1.41.0-wmf.12; 2023-06-06).Jun 9 2023, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 9 2023, 1:10 PM
gerritbot added a comment.Jun 20 2023, 3:55 PM

Change 931636 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] i18n: Fix en.json for time to complete section image recommendation

https://gerrit.wikimedia.org/r/931636

gerritbot added a project: Patch-For-Review.Jun 20 2023, 3:55 PM
gerritbot added a comment.Jun 20 2023, 3:58 PM

Change 931639 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] i18n: Fix en.json for image and section image recommendation task type description

https://gerrit.wikimedia.org/r/931639

gerritbot added a comment.Jun 20 2023, 4:05 PM

Change 931641 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] i18n: Onboarding dialog en.json fixes

https://gerrit.wikimedia.org/r/931641

gerritbot added a comment.Jun 20 2023, 5:56 PM

Change 931664 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] i18n: Fix en.json for addimage details dialog

https://gerrit.wikimedia.org/r/931664

kostajh updated the task description. (Show Details)Jun 20 2023, 7:28 PM
kostajh updated the task description. (Show Details)
kostajh moved this task from In Progress to QA on the Growth-Team (Current Sprint) board.

I think we're OK with this task with the above patches, none of which should block the release IMHO as they are all minor adjustments to match the copy doc.

Engineers Add/edit the TWN description field for TranslateWiki (Growth team)
Engineers Add the corresponding field name (Engineering)

I didn't do this part as I'm pressed for time.

gerritbot added a comment.Jun 20 2023, 7:36 PM

Change 931636 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] i18n: Fix en.json for time to complete section image recommendation

https://gerrit.wikimedia.org/r/931636

gerritbot added a comment.Jun 20 2023, 7:37 PM

Change 931639 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] i18n: Fix en.json for image and section image recommendation task type description

https://gerrit.wikimedia.org/r/931639

gerritbot added a comment.Jun 20 2023, 7:39 PM

Change 931641 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] i18n: Onboarding dialog en.json fixes

https://gerrit.wikimedia.org/r/931641

gerritbot added a comment.Jun 20 2023, 7:39 PM

Change 931664 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] i18n: Fix en.json for addimage details dialog

https://gerrit.wikimedia.org/r/931664

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.15; 2023-06-27); removed MW-1.41-notes (1.41.0-wmf.13; 2023-06-13).Jun 20 2023, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 20 2023, 8:10 PM
Etonkovidova closed this task as Resolved.Jun 29 2023, 9:13 PM
Etonkovidova updated the task description. (Show Details)
RHo mentioned this in T338171: Revise UI copy for temporary accounts.Jul 3 2023, 1:44 PM
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL