@nettrom_WMF would you like separate schemas (where it makes sense, e.g. mediawiki/page/image-suggestions-feedback) or should we just plug in a section ID into the schema, and set it to null for the old image recommendation task type? Do you want a specific format for the section ID (ordinal, section title text etc)?

In T335716#8833119, @Tgr wrote:

@nettrom_WMF would you like separate schemas (where it makes sense, e.g. mediawiki/page/image-suggestions-feedback) or should we just plug in a section ID into the schema, and set it to null for the old image recommendation task type? Do you want a specific format for the section ID (ordinal, section title text etc)?

I think we should reuse as much of our schemas and instrumentation as we can since the workflow is almost identical to that of the old Add an Image task. While perhaps a bit redundant, capturing both the ordinal and the section title would give us a much information as possible to work with in case we need to dig deeper (e.g. the text makes it easier to find the section, the ordinal could give us information about whether earlier sections are more likely to have/get images). Then those can be set to null for the old task, as you suggest.

Change 924879 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[schemas/event/secondary@master] Add schema for section_image_suggestion_interaction

https://gerrit.wikimedia.org/r/924879

Change 924881 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Section images: use new interaction logger

https://gerrit.wikimedia.org/r/924881

Change 926468 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[schemas/event/secondary@master] Add section title and ordinal in image suggestions submission events

https://gerrit.wikimedia.org/r/926468

Change 924879 merged by jenkins-bot:

[schemas/event/secondary@master] Add section title and ordinal in the image_suggestion_interaction schema

https://gerrit.wikimedia.org/r/924879

Change 924881 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Section images: bump instrumentation schema to 1.4.1

https://gerrit.wikimedia.org/r/924881

Change 926468 merged by jenkins-bot:

[schemas/event/secondary@master] Add section title and ordinal in image suggestions submission events

https://gerrit.wikimedia.org/r/926468

Change 928800 had a related patch set uploaded (by Elukey; author: Elukey):

[eventgate-wikimedia@master] Bump secondary schema repository commit sha

https://gerrit.wikimedia.org/r/928800

Change 928800 merged by Milimetric:

[eventgate-wikimedia@master] Bump secondary schema repository commit sha

https://gerrit.wikimedia.org/r/928800

Change 929164 had a related patch set uploaded (by Btullis; author: Btullis):

[operations/deployment-charts@master] Deploy the new eventgate-wikimedia container image

https://gerrit.wikimedia.org/r/929164

Change 929164 merged by jenkins-bot:

[operations/deployment-charts@master] Deploy the new eventgate-wikimedia container image

https://gerrit.wikimedia.org/r/929164

@KStoller-WMF, @Etonkovidova is out at on offsite this week. Would you like to assign QA of this one to an engineer, or do you want to review the events emitted via interactions with add image and add section image to make sure everything's as you'd expect?

@nettrom_WMF - at our 1:1 today, let's QA this together, so you can ensure we are gathering the data you need and I can learn how to review instrumentation events.

I introduced console-based event QA to @KStoller-WMF in our 1:1. We went through most of the workflow and checked the various events. From what we found the instrumentation is working correctly, there's nothing there that blocks deployment.

I believe I found a discrepancy between the documentation and the event data. https://gerrit.wikimedia.org/r/924879 says that section data is included for all section-level events, but from what I found it's only the action = "impression" event with active_interface = "machinesuggestions_mode" that contains section-level data in action_data. From my point of view, I think it's fine to keep the events the way they are but update the schema documentation to reflect that it's the impression event that defines the session as either "section level" – meaning action_data contains the section ordinal and title – or "article level" meaning there's no additional data.

Change #1059254 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[schemas/event/secondary@master] docs(image_suggestion_interaction): fix doc message

https://gerrit.wikimedia.org/r/1059254

Updated to For action=impression with "machinesuggestions_mode" active_interface when the suggestion is for a section image, cc @nettrom_WMF

Change #1059254 merged by jenkins-bot:

[schemas/event/secondary@master] docs(image_suggestion_interaction): fix doc message

https://gerrit.wikimedia.org/r/1059254

Moving to QA since it seems the task has not been tested, but @Etonkovidova can confirm.

Checked in beta - mediawiki.structured_task.article.image_suggestion_interaction (https://schema.wikimedia.org/#!//secondary/jsonschema/analytics/mediawiki/structured_task/article/image_suggestion_interaction) for few user workflows scenarios

• viewing/navigating/dismissing the intro tour
• viewing suggested image details
• interaction with a caption field
• accepting/rejecting/skipping a suggested image

All user actions seem to be captured (mobile was also checked).

Comparing the AC criteria with the example on example of mediawiki/structured_task/article/image_suggestion_interaction event and what info was recorded - all AC are in place; a User ID is not directly recorded, but homepage_pageview_token could be compared with Homepage module schema.

Moving to Test in Production (and pinging @nettrom_WMF to flag the task ready for further checking ).
The example - from cswiki wmf.26

$schema: "/analytics/mediawiki/structured_task/article/image_suggestion_interaction/1.4.1"
action: "impression"
action_data: ""
active_interface: "machinesuggestions_mode"
dt: "2024-10-10T23:52:44.436Z"
homepage_pageview_token: "p3rr[...]"
is_mobile: false
meta: {stream: 'mediawiki.structured_task.article.image_suggestion_interaction', domain: 'cs.wikipedia.org'}
newcomer_task_token: "trh[...{"
page_id: 1238501
page_title: "Žlutý hyperobr"