Page MenuHomePhabricator
Create Task
Maniphest T335748

Migrate Database::delete usages to DeleteQueryBuilder in PageTriage
Closed, ResolvedPublic
Actions

Description

Per a wikitech-l email

Refactor $dbw->delete to $dbw->newDeleteQueryBuilder()

Example gerrit patch

Relevant codesearch

Details

SubjectRepoBranchLines +/-
Migrate delete query statements to newDeleteQueryBuildermediawiki/extensions/PageTriagemaster+82 -41
Customize query in gerrit

Related Objects
Search...

Event Timeline

Novem_Linguae created this task.May 2 2023, 9:44 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptMay 2 2023, 9:44 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Novem_Linguae updated the task description. (Show Details)May 2 2023, 9:50 AM
Novem_Linguae moved this task from Backlog to Priority technical debt on the PageTriage board.
kostajh moved this task from Inbox to Triaged on the Growth-Team board.May 4 2023, 7:00 PM
Samwalton9-WMF added a project: Moderator-Tools-Team (Kanban).May 8 2023, 5:00 PM
Scardenasmolinar changed the task status from Open to In Progress.Jun 6 2023, 5:30 PM
Scardenasmolinar claimed this task.
Scardenasmolinar moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
gerritbot added a comment.Jun 8 2023, 2:24 AM

Change 928185 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/PageTriage@master] Migrate delete query statements to newDeleteQueryBuilder

https://gerrit.wikimedia.org/r/928185

gerritbot added a project: Patch-For-Review.Jun 8 2023, 2:24 AM
Scardenasmolinar moved this task from In Progress to Code review on the Moderator-Tools-Team (Kanban) board.Jun 9 2023, 4:21 AM

All of the updated queries are already covered by tests, so I'll go ahead and mark the ticket for review.

gerritbot added a comment.Jun 14 2023, 5:30 PM

Change 928185 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Migrate delete query statements to newDeleteQueryBuilder

https://gerrit.wikimedia.org/r/928185

Scardenasmolinar moved this task from Code review to Done on the Moderator-Tools-Team (Kanban) board.Jun 14 2023, 5:51 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 14 2023, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 14 2023, 6:10 PM
Samwalton9-WMF closed this task as Resolved.Jun 30 2023, 11:31 AM
MPGuy2824 mentioned this in T348835: Migrate code to use new query builder functions.Oct 13 2023, 7:47 AM
MPGuy2824 added a parent task: T348835: Migrate code to use new query builder functions.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL