Page MenuHomePhabricator

All icons in Language Selector component are missing
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

image.png (203×510 px, 8 KB)

What should have happened instead?:

image.png (177×444 px, 6 KB)

Other information (browser name/version, screenshots, etc.):

This is caused by the image URL being given as /img/clear.svg, notably missing the /querybuilder/ part of the path. If that is added in manually, the image appears correctly.

One way would be to fix the path (it does work for the logo, though that is defined in CSS). Another way would be to inline the SVG, similar to what we did for the Wikit SVGs.

Also, based on the network panel, the same problem exists for search.svg and close.svg

Event Timeline

This is how the current component looks on mobile (Chrome on iOS) due to the missing icons:

image.png (1×828 px, 154 KB)

Sarai-WMDE renamed this task from "Clear Input" icon missing in Language Selector to All icons in Language Selector component are missing.May 10 2023, 1:57 PM
noarave set the point value for this task to 3.Jun 1 2023, 9:18 AM

Change 927209 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[wikidata/query-builder@master] Fix image URLs in build

https://gerrit.wikimedia.org/r/927209

Change 927209 merged by jenkins-bot:

[wikidata/query-builder@master] Fix image URLs in build

https://gerrit.wikimedia.org/r/927209

I think this needs to be deployed before it can be product verified (at least, it doesn’t seem to be fixed on https://query.wikidata.org/querybuilder/ yet).

Change 927990 had a related patch set uploaded (by WDQSGuiBuilder; author: WDQSGuiBuilder):

[wikidata/query-builder/deploy@production] Merging from 4621760b39eb7089a4467b5e44bd3dd86be0bccb

https://gerrit.wikimedia.org/r/927990

Change 927990 merged by Lucas Werkmeister (WMDE):

[wikidata/query-builder/deploy@production] Merging from 4621760b39eb7089a4467b5e44bd3dd86be0bccb

https://gerrit.wikimedia.org/r/927990

Arian_Bozorg subscribed.

This is looking good to me!