Page MenuHomePhabricator
Create Task
Maniphest T335783

Remove temporary feature flag for wbsubscribers API output path
Closed, ResolvedPublic
Actions

Description

The feature flag $wgWBRepoSettings['tmpWbsubscribersSensibleOutput'] was only introduced temporarily to enable a controlled roll-out. Now that the roll-out is finished, we can remove it again.

See the changes associated with the parent task and subtasks for code that was added and now needs to be cleaned up.

A (likely incomplete) list of places to clean up:

  • Wikibase.default.php
  • ListSubscribers.php
  • wmf-config/Wikibase.php
  • wmf-config/InitialiseSettings-labs.php:2347

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove wmgWikibaseTmpWbsubscribersSensibleOutput feature flagoperations/mediawiki-configmaster+0 -11
Remove tmpWbsubscribersSensibleOutput feature flagmediawiki/extensions/Wikibasemaster+10 -40
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.May 2 2023, 2:59 PM
ItamarWMDE changed the task status from Open to Stalled.May 9 2023, 1:27 PM
ItamarWMDE added a comment.May 9 2023, 1:33 PM

Task review

  • The task is actually a subtask of [T300458] And thus will be moved to our work board
  • The task in marked as stalled until the 22nd of May, which is when the time to review this breaking change on testwikidata comes to a close.
ItamarWMDE edited projects, added [Archived]Wikidata Dev Team (Sprint-∞); removed [Archived]Wikidata Dev Team.May 9 2023, 1:34 PM
ItamarWMDE moved this task from Incoming to Ongoing on the wmde-wikidata-tech board.
Lucas_Werkmeister_WMDE changed the task status from Stalled to Open.May 26 2023, 2:40 PM
Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE moved this task from Parents/Waiting to Doing on the [Archived]Wikidata Dev Team (Sprint-∞) board.
Lucas_Werkmeister_WMDE removed a subscriber: LucasWerkmeister.
gerritbot added a comment.May 26 2023, 2:44 PM

Change 923618 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove tmpWbsubscribersSensibleOutput feature flag

https://gerrit.wikimedia.org/r/923618

gerritbot added a project: Patch-For-Review.May 26 2023, 2:44 PM
Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the [Archived]Wikidata Dev Team (Sprint-∞) board.May 26 2023, 2:44 PM
gerritbot added a comment.May 26 2023, 2:47 PM

Change 923619 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[operations/mediawiki-config@master] Remove wmgWikibaseTmpWbsubscribersSensibleOutput feature flag

https://gerrit.wikimedia.org/r/923619

hoo moved this task from Peer Review to Tech Verification on the [Archived]Wikidata Dev Team (Sprint-∞) board.May 30 2023, 8:42 AM
gerritbot added a comment.May 30 2023, 11:00 AM

Change 923618 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove tmpWbsubscribersSensibleOutput feature flag

https://gerrit.wikimedia.org/r/923618

Lucas_Werkmeister_WMDE changed the task status from Open to Stalled.May 30 2023, 11:33 AM
Lucas_Werkmeister_WMDE moved this task from Tech Verification to Parents/Waiting on the [Archived]Wikidata Dev Team (Sprint-∞) board.

Stalled until 1.41.0-wmf.12 is fully rolled out, i.e. we can probably deploy the config change after June 12.

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.12; 2023-06-06).May 30 2023, 1:01 PM
Reedy moved this task from Unsorted to Non-core-API stuff on the MediaWiki-Action-API board.Jun 5 2023, 12:46 AM
gerritbot added a comment.Jun 12 2023, 1:47 PM

Change 923619 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove wmgWikibaseTmpWbsubscribersSensibleOutput feature flag

https://gerrit.wikimedia.org/r/923619

Stashbot added a comment.Jun 12 2023, 1:47 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-12T13:47:44Z] <lucaswerkmeister-wmde@deploy1002> Started scap: Backport for [[gerrit:923619|Remove wmgWikibaseTmpWbsubscribersSensibleOutput feature flag (T335783)]]

Stashbot added a comment.Jun 12 2023, 1:51 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-12T13:51:20Z] <lucaswerkmeister-wmde@deploy1002> lucaswerkmeister-wmde: Backport for [[gerrit:923619|Remove wmgWikibaseTmpWbsubscribersSensibleOutput feature flag (T335783)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet

Stashbot added a comment.Jun 12 2023, 1:54 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-12T13:54:39Z] <lucaswerkmeister-wmde@deploy1002> Finished scap: Backport for [[gerrit:923619|Remove wmgWikibaseTmpWbsubscribersSensibleOutput feature flag (T335783)]] (duration: 06m 54s)

Lucas_Werkmeister_WMDE changed the task status from Stalled to Open.Jun 12 2023, 2:03 PM
Lucas_Werkmeister_WMDE moved this task from Parents/Waiting to Tech Verification on the [Archived]Wikidata Dev Team (Sprint-∞) board.
Maintenance_bot removed a project: Patch-For-Review.Jun 12 2023, 2:10 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.Jun 21 2023, 11:28 AM
Lucas_Werkmeister_WMDE moved this task from Tech Verification to Our work done on the [Archived]Wikidata Dev Team (Sprint-∞) board.

Doesn’t look like there are any references left (this search covers both config and source code):

lucaswerkmeister-wmde@deploy1002 /srv/mediawiki-staging (master $ u=) $ grep -rlF -e tmpEnableLabelsInApiSummaries -e tmpWbsubscribersSensibleOutput
lucaswerkmeister-wmde@deploy1002 /srv/mediawiki-staging (master $ u=) $
karapayneWMDE moved this task from Our work done to 2023 completed tasks on the [Archived]Wikidata Dev Team (Sprint-∞) board.Jun 28 2023, 7:48 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits