Deprecate and remove mediawiki.ui variables
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Background

With T332541 close to resolution, it's time to deprecate and remove mediawiki.ui variables.

Goal

A single source of truth has been established with mediawiki.skin.variables, which features several benefits over mediawiki.ui variables.
Let's deprecate and remove former file.

Note, in contrast to resources defined in resources.php, we need to rely on manual work and only comments with Less files.

Acceptance criteria

Deprecate mediawiki.ui/variables.less file, done in MW-1.41.0
Remove one MW version later, targeted for MW-1.42.0

Details

	Subject	Repo	Branch	Lines +/-
	mediawiki.less: Remove 'mediawiki.ui/variables.less' completely	mediawiki/core	master	+2 -139
	mediawiki.ui: Clearly deprecate the whole variables.less file	mediawiki/core	master	+14 -9

Customize query in gerrit

Related Objects

Mentioned In: T332541: Replace mediawiki.ui variables with mediawiki.skin.variables
Mentioned Here: T333888: Provide a better-tailored mediawiki.skin.variables experience to Monobook
T332541: Replace mediawiki.ui variables with mediawiki.skin.variables

Event Timeline

Volker_E created this task.May 2 2023, 10:00 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 2 2023, 10:00 PM

Change 914410 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] mediawiki.ui: Clearly deprecate the whole variables.less file

https://gerrit.wikimedia.org/r/914410

gerritbot added a project: Patch-For-Review.May 2 2023, 10:04 PM

Volker_E edited projects, added Design-System-Team (Design-System-Sprint); removed Design-System-Team.May 3 2023, 10:57 AM

Restricted Application triaged this task as High priority. · View Herald TranscriptMay 3 2023, 10:57 AM

Volker_E set the point value for this task to 1.May 3 2023, 10:58 AM

Volker_E mentioned this in T332541: Replace mediawiki.ui variables with mediawiki.skin.variables.May 4 2023, 9:58 AM

Change 914410 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.ui: Clearly deprecate the whole variables.less file

https://gerrit.wikimedia.org/r/914410

Maintenance_bot removed a project: Patch-For-Review.May 4 2023, 8:11 PM

Volker_E updated the task description. (Show Details)May 6 2023, 7:56 PM

Change 916797 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] [WIP] mediawiki.less: Remove 'mediawiki.ui/variables.less' completely

https://gerrit.wikimedia.org/r/916797

gerritbot added a project: Patch-For-Review.May 6 2023, 8:08 PM

With first step removing from Design Systems Team Sprint board, as second step needs to wait for MW 1.42.0. @CCiufo-WMF @ldelench_wmf

Volker_E added a subscriber: ldelench_wmf.May 6 2023, 8:19 PM

@Volker_E will this be included in the release notes automatically in the right channels? i.e. wikitech-l, etc.?

Yes, that's a good call.
There's two things to put forward to wikitech-l:

Writing about the positive impact of mediawiki.skin.variables for all, skin, extension authors and our users.
What do Monobook users expect, who wants to participate about the look & feel for this still popular skin. See T333888: Provide a better-tailored mediawiki.skin.variables experience to Monobook. Similar but probably not as urgent would be Timeless skin as other Foundation deployed skin.

We could also consider to add a short tech news message, targeted at end users, that their interface might slightly change (easy example: border radius on Monobook; towards more consistency)

CCiufo-WMF moved this task from Inbox to Backlog on the Design-System-Team board.May 9 2023, 1:55 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 16 2023, 10:01 AM

Volker_E updated the task description. (Show Details)Oct 18 2023, 4:52 PM

Volker_E changed the task status from Stalled to In Progress.Jan 11 2024, 12:31 AM

Volker_E claimed this task.

Change 916797 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.less: Remove 'mediawiki.ui/variables.less' completely

https://gerrit.wikimedia.org/r/916797

Maintenance_bot removed a project: Patch-For-Review.Jan 13 2024, 1:30 AM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.14; 2024-01-16).Jan 13 2024, 2:00 AM

Volker_E closed this task as Resolved.Jan 16 2024, 12:27 AM

Volker_E updated the task description. (Show Details)

Volker_E added a subscriber: Jdlrobson.

Deprecate and remove mediawiki.ui variablesClosed, ResolvedPublic1 Estimated Story PointsActions