Page MenuHomePhabricator

Update cx_section_translations table
Closed, ResolvedPublic

Description

Progress:

  • testwiki s3
  • wikishared x1

Event Timeline

Change 903222 had a related patch set uploaded (by KartikMistry; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] Add new fields the "cx_section_translations" table

https://gerrit.wikimedia.org/r/903222

KartikMistry updated the task description. (Show Details)

@KartikMistry is this a schema change ticket? If so, please could you follow the procedure and template at https://wikitech.wikimedia.org/wiki/Schema_changes#Workflow_of_a_schema_change
We receive a large volume of schema change tickets, so we try to make sure they are all having the same template to avoid confusions and to process them as fast as we can.

If it is not meant to be a schema change ticket yet, then all good! :)

KartikMistry updated the task description. (Show Details)

@KartikMistry is this a schema change ticket? If so, please could you follow the procedure and template at https://wikitech.wikimedia.org/wiki/Schema_changes#Workflow_of_a_schema_change
We receive a large volume of schema change tickets, so we try to make sure they are all having the same template to avoid confusions and to process them as fast as we can.

If it is not meant to be a schema change ticket yet, then all good! :)

Thanks. Updated task.

Thanks!
One question:

When to run those changes: Before the train on the following Monday or Tuesday (8th or 9th May)

Is that a hard requirement? Like, it has to be done at that time/day or we can do it anytime as long as it is before those dates? Also, what happens if we cannot do it before those dates? Having hard deadlines on schema changes isn't a good practice, as some of them can take months to be done (eg: big tables that requires the change to be done replica by replica).

We also need this patch to be merged to be able to start the schema change.

Thanks!
One question:

When to run those changes: Before the train on the following Monday or Tuesday (8th or 9th May)

Is that a hard requirement? Like, it has to be done at that time/day or we can do it anytime as long as it is before those dates? Also, what happens if we cannot do it before those dates? Having hard deadlines on schema changes isn't a good practice, as some of them can take months to be done (eg: big tables that requires the change to be done replica by replica).

No hard requirement as I confirmed with team that the change is backward compatible. We will merge the patch, but then followup patches are based on this change, so good to deploy this change before next train.

Excellent. My point is that it is very unlikely we'll be able to deploy this before next train. Especially if the patch isn't even merged yet :)

Change 903222 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Add new fields the "cx_section_translations" table

https://gerrit.wikimedia.org/r/903222

Marostegui moved this task from Triage to Ready on the DBA board.

@KartikMistry I have deployed this change on s3 (testwiki) so you can test there.

Mentioned in SAL (#wikimedia-operations) [2023-05-03T08:39:42Z] <marostegui> dbmaint deploy schema change on eqiad s3 with replication T335834

@KartikMistry I have deployed this change on s3 (testwiki) so you can test there.

Thanks!

@Marostegui We can proceed with production deployment for this schema change.

Mentioned in SAL (#wikimedia-operations) [2023-05-08T04:54:14Z] <marostegui> Deploy schema change on x1 eqiad wikishared with replication dbmaint T335834

Marostegui updated the task description. (Show Details)