Page MenuHomePhabricator

Update buttons in user links and page toolbar to use the new button markup
Closed, ResolvedPublic2 Estimated Story Points

Description

Description

The watchlist, echo links, watchstar, wikilove buttons are still using the outdated button markup, and they need to be updated for the adoption of the Codex button styles. The classes and markup for these buttons are handled by Hooks.php, which was not covered by the changes in T334881.

This patch will handle those remaining buttons to have the new button markup, i.e.

<button class="mw-ui-button mw-ui-quiet">
  <span class="mw-ui-icon mw-ui-icon-wikimedia-star"> </span>
</button>

AC

  • No visual changes
  • The watchstar maintains the same behavior of spinning and changing icon when clicked

Developer Notes

This requires changes to Hooks.php, and changes to the watchstar hook in core. Because the buttons in the page toolbar (i.e. wikilove and watchstar) use the new data/template approach, additional changes might be needed in core to pass through additional template data (i.e. icon size). See convo here for more context.

Event Timeline

Change 914387 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Update user menu and watchstar buttons to be consistent with spec

https://gerrit.wikimedia.org/r/914387

Jdlrobson triaged this task as Medium priority.May 4 2023, 5:06 PM
Jdlrobson subscribed.

I'm gonna do a git bisect today to work out what happened here.

Change 914387 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Update user menu and watchstar buttons to be consistent with spec

https://gerrit.wikimedia.org/r/914387

Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: No visual changes
✅ AC2: The watchstar maintains the same behavior of spinning and changing icon when clicked

Screen Recording 2023-05-16 at 3.49.19 PM.mov.gif (696×1 px, 563 KB)

Screen Recording 2023-05-16 at 3.48.33 PM.mov.gif (696×1 px, 480 KB)

Jdlrobson claimed this task.
Jdlrobson updated the task description. (Show Details)

Neato. I also quickly checked this in production. https://en.wikipedia.org/wiki/User:
Drewniak_(WMF)

Screenshot 2023-05-16 at 4.14.13 PM.png (311×949 px, 96 KB)