Description
The watchlist, echo links, watchstar, wikilove buttons are still using the outdated button markup, and they need to be updated for the adoption of the Codex button styles. The classes and markup for these buttons are handled by Hooks.php, which was not covered by the changes in T334881.
This patch will handle those remaining buttons to have the new button markup, i.e.
<button class="mw-ui-button mw-ui-quiet"> <span class="mw-ui-icon mw-ui-icon-wikimedia-star"> </span> </button>
AC
- No visual changes
- The watchstar maintains the same behavior of spinning and changing icon when clicked
Developer Notes
This requires changes to Hooks.php, and changes to the watchstar hook in core. Because the buttons in the page toolbar (i.e. wikilove and watchstar) use the new data/template approach, additional changes might be needed in core to pass through additional template data (i.e. icon size). See convo here for more context.


