Page MenuHomePhabricator

mw-tag-marker border radius too small on mobile versions
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:
Buttons lost their style.

What should have happened instead?:
Buttons should have less rounded corners.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
Class: mw-tag-marker mw-tag-marker-mobile_edit

m.wikidata.org.png (696×540 px, 94 KB)

Event Timeline

Thanks for reporting this! Confirming. For comparison, here is a screenshot from 1.41.0-wmf.6:

T335932---1.41.0-wmf.6.png (491×1 px, 43 KB)

.mw-tag-marker in wmf.7 has border-radius: 50%;.
wmf.6 had border-radius: 1.6em;

Aklapper renamed this task from mobile version buttons lost style to mw-tag-marker border radius broken on mobile versions.May 4 2023, 9:47 AM
Aklapper renamed this task from mw-tag-marker border radius broken on mobile versions to mw-tag-marker border radius too small on mobile versions.
Jdlrobson subscribed.

Im guessing this is related to T330966: "Show IP" button on Special:Contributions while using MinervaNeue skin needs styling fixes since recent changes shares styles with the contributions page OR the recent switch away from mediawiki ui variables (T332541: Replace mediawiki.ui variables with mediawiki.skin.variables)

Provisionally tagging with a few people / teams until we've worked out the cause.

LGoto triaged this task as Medium priority.May 4 2023, 5:06 PM
LGoto moved this task from Incoming to Not ready to estimate on the Web-Team-Backlog-Archived board.

Change 916421 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/skins/MinervaNeue@master] styles: Use appropriate tag marker `@border-radius-pill` token

https://gerrit.wikimedia.org/r/916421

Change 916421 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] styles: Use appropriate tag marker `@border-radius-pill` token

https://gerrit.wikimedia.org/r/916421

Restricted Application raised the priority of this task from Medium to High. · View Herald TranscriptMay 5 2023, 4:08 PM
ldelench_wmf set the point value for this task to 1.May 5 2023, 4:11 PM