Mobile preferences: Notifications section is not clickable: No infusion data found
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Func
	May 6 2023, 5:52 PM

Description

Steps to replicate the issue (include links if applicable):

Navigate to https://m.mediawiki.org/wiki/Special:Preferences?uselang=en
Click on the Notifications section

What happens?:

The Notifications section didn't open, with errors thrown:

Uncaught Error: No infusion data found: mw-input-wpecho-subscriptions-web-edit-user-page

What should have happened instead?:

The Notifications section opened and usable.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
preferences: Follow-up to commit b2062d11	mediawiki/core	REL1_40	+5 -1
preferences: vary mobile toggle/checkbox sync	mediawiki/core	master	+36 -18
preferences: Skip altering non-infusable checkbox widgets	mediawiki/core	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: rMWc1b1c6f81c43: preferences: Sync states between hidden checkbox and toggle widgets

Event Timeline

Func created this task.May 6 2023, 5:52 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 6 2023, 5:52 PM

Change 915803 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] preferences: Skip altering non-infusable checkbox widgets

https://gerrit.wikimedia.org/r/915803

gerritbot added a project: Patch-For-Review.May 6 2023, 6:26 PM

Scardenasmolinar assigned this task to Func.May 8 2023, 5:03 PM

Scardenasmolinar added a project: Moderator-Tools-Team (Kanban).

Scardenasmolinar moved this task from Ready to Eng review on the Moderator-Tools-Team (Kanban) board.

jsn.sherman moved this task from Eng review to Done on the Moderator-Tools-Team (Kanban) board.May 8 2023, 5:44 PM

Change 915803 merged by jenkins-bot:

[mediawiki/core@master] preferences: Skip altering non-infusable checkbox widgets

https://gerrit.wikimedia.org/r/915803

Maintenance_bot removed a project: Patch-For-Review.May 8 2023, 6:10 PM

I went ahead and merged this in since it fixes production errors; the upshot is that we're now left with quite a few checkboxes in mobile preferences. since many are not infusible, which is why I wasn't infusing them in the first place. I'm working on another patch to add back in the old behavior for non-infusible checkboxes.

Change 917401 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/core@master] preferences: vary mobilelayout toggle/checbox sync

https://gerrit.wikimedia.org/r/917401

gerritbot added a project: Patch-For-Review.May 8 2023, 7:34 PM

jsn.sherman moved this task from Done to Eng review on the Moderator-Tools-Team (Kanban) board.May 8 2023, 7:36 PM

In T336108#8834514, @jsn.sherman wrote:

I went ahead and merged this in since it fixes production errors; the upshot is that we're now left with quite a few checkboxes in mobile preferences. since many are not infusible, which is why I wasn't infusing them in the first place. I'm working on another patch to add back in the old behavior for non-infusible checkboxes.

Hum... Only checkboxes in the checkMatrixWidget are not infusable; for some other random checkboxes, that's because the checkboxElement was replaced during infusion, so it references to an element outside of the DOM tree. And unfortunately, in my test environment, all preferences are global so they have already been infused before insertToggles(), so no change during infusion, then I am not able to spot this issue testing commit c1b1c6f81...