Page MenuHomePhabricator

Cannot read properties of null (reading 'getAttribute')
Closed, ResolvedPublicBUG REPORT

Description

Bug fetched from Logstash.

https://logstash.wikimedia.org/app/discover#/doc/logstash-*/logstash-default-1-7.0.0-1-2023.05.08?id=y2e3_IcBnUsAfeivnGjC

What happens?:
SearchVue is unable to parse the results and fail to add the new functionality on some pages/devices

What should have happened instead?:
Searchvue should fail quickly when one of the result cannot be parsed and should NOT affect the rest of the result set

Callstack:
at Proxy.mounted https://ru.m.wikipedia.org/w/load.php?lang=ru&modules=%40vue%2Fcomposition-api%2C%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%2CsearchVue%2Cvue%2Cvuex%7Cext.advancedSearch.elements%2Cinit%2Cstyles%7Cext.cirrus.serp%7Cjquery.highlightText%2Csuggestions%7Cmediawiki.searchSuggest%2Cwidgets%7Cmediawiki.special.search%7Cmediawiki.special.search.commonsInterwikiWidget%7Cmediawiki.widgets.SearchInputWidget%7Coojs-ui-widgets.icons%7Coojs-ui.styles.icons-content%2Cicons-editing-advanced%2Cicons-interactions%2Cicons-layout&skin=minerva&version=13zfi:488:772
at Vt https://ru.m.wikipedia.org/w/load.php?lang=ru&modules=%40vue%2Fcomposition-api%2C%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%2CsearchVue%2Cvue%2Cvuex%7Cext.advancedSearch.elements%2Cinit%2Cstyles%7Cext.cirrus.serp%7Cjquery.highlightText%2Csuggestions%7Cmediawiki.searchSuggest%2Cwidgets%7Cmediawiki.special.search%7Cmediawiki.special.search.commonsInterwikiWidget%7Cmediawiki.widgets.SearchInputWidget%7Coojs-ui-widgets.icons%7Coojs-ui.styles.icons-content%2Cicons-editing-advanced%2Cicons-interactions%2Cicons-layout&skin=minerva&version=13zfi:558:789
at Bt https://ru.m.wikipedia.org/w/load.php?lang=ru&modules=%40vue%2Fcomposition-api%2C%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%2CsearchVue%2Cvue%2Cvuex%7Cext.advancedSearch.elements%2Cinit%2Cstyles%7Cext.cirrus.serp%7Cjquery.highlightText%2Csuggestions%7Cmediawiki.searchSuggest%2Cwidgets%7Cmediawiki.special.search%7Cmediawiki.special.search.commonsInterwikiWidget%7Cmediawiki.widgets.SearchInputWidget%7Coojs-ui-widgets.icons%7Coojs-ui.styles.icons-content%2Cicons-editing-advanced%2Cicons-interactions%2Cicons-layout&skin=minerva&version=13zfi:558:867
at No.t.weh.t.weh https://ru.m.wikipedia.org/w/load.php?lang=ru&modules=%40vue%2Fcomposition-api%2C%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%2CsearchVue%2Cvue%2Cvuex%7Cext.advancedSearch.elements%2Cinit%2Cstyles%7Cext.cirrus.serp%7Cjquery.highlightText%2Csuggestions%7Cmediawiki.searchSuggest%2Cwidgets%7Cmediawiki.special.search%7Cmediawiki.special.search.commonsInterwikiWidget%7Cmediawiki.widgets.SearchInputWidget%7Coojs-ui-widgets.icons%7Coojs-ui.styles.icons-content%2Cicons-editing-advanced%2Cicons-interactions%2Cicons-layout&skin=minerva&version=13zfi:577:508
at cn https://ru.m.wikipedia.org/w/load.php?lang=ru&modules=%40vue%2Fcomposition-api%2C%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%2CsearchVue%2Cvue%2Cvuex%7Cext.advancedSearch.elements%2Cinit%2Cstyles%7Cext.cirrus.serp%7Cjquery.highlightText%2Csuggestions%7Cmediawiki.searchSuggest%2Cwidgets%7Cmediawiki.special.search%7Cmediawiki.special.search.commonsInterwikiWidget%7Cmediawiki.widgets.SearchInputWidget%7Coojs-ui-widgets.icons%7Coojs-ui.styles.icons-content%2Cicons-editing-advanced%2Cicons-interactions%2Cicons-layout&skin=minerva&version=13zfi:560:189
at X https://ru.m.wikipedia.org/w/load.php?lang=ru&modules=%40vue%2Fcomposition-api%2C%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%2CsearchVue%2Cvue%2Cvuex%7Cext.advancedSearch.elements%2Cinit%2Cstyles%7Cext.cirrus.serp%7Cjquery.highlightText%2Csuggestions%7Cmediawiki.searchSuggest%2Cwidgets%7Cmediawiki.special.search%7Cmediawiki.special.search.commonsInterwikiWidget%7Cmediawiki.widgets.SearchInputWidget%7Coojs-ui-widgets.icons%7Coojs-ui.styles.icons-content%2Cicons-editing-advanced%2Cicons-interactions%2Cicons-layout&skin=minerva&version=13zfi:609:457
at mount https://ru.m.wikipedia.org/w/load.php?lang=ru&modules=%40vue%2Fcomposition-api%2C%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%2CsearchVue%2Cvue%2Cvuex%7Cext.advancedSearch.elements%2Cinit%2Cstyles%7Cext.cirrus.serp%7Cjquery.highlightText%2Csuggestions%7Cmediawiki.searchSuggest%2Cwidgets%7Cmediawiki.special.search%7Cmediawiki.special.search.commonsInterwikiWidget%7Cmediawiki.widgets.SearchInputWidget%7Coojs-ui-widgets.icons%7Coojs-ui.styles.icons-content%2Cicons-editing-advanced%2Cicons-interactions%2Cicons-layout&skin=minerva&version=13zfi:594:678
at Xc.t.mount https://ru.m.wikipedia.org/w/load.php?lang=ru&modules=%40vue%2Fcomposition-api%2C%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%2CsearchVue%2Cvue%2Cvuex%7Cext.advancedSearch.elements%2Cinit%2Cstyles%7Cext.cirrus.serp%7Cjquery.highlightText%2Csuggestions%7Cmediawiki.searchSuggest%2Cwidgets%7Cmediawiki.special.search%7Cmediawiki.special.search.commonsInterwikiWidget%7Cmediawiki.widgets.SearchInputWidget%7Coojs-ui-widgets.icons%7Coojs-ui.styles.icons-content%2Cicons-editing-advanced%2Cicons-interactions%2Cicons-layout&skin=minerva&version=13zfi:639:869
at HTMLDocument.<anonymous> https://ru.m.wikipedia.org/w/load.php?lang=ru&modules=%40vue%2Fcomposition-api%2C%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%2CsearchVue%2Cvue%2Cvuex%7Cext.advancedSearch.elements%2Cinit%2Cstyles%7Cext.cirrus.serp%7Cjquery.highlightText%2Csuggestions%7Cmediawiki.searchSuggest%2Cwidgets%7Cmediawiki.special.search%7Cmediawiki.special.search.commonsInterwikiWidget%7Cmediawiki.widgets.SearchInputWidget%7Coojs-ui-widgets.icons%7Coojs-ui.styles.icons-content%2Cicons-editing-advanced%2Cicons-interactions%2Cicons-layout&skin=minerva&version=13zfi:484:840
at mightThrow https://ru.m.wikipedia.org/w/load.php?lang=ru&modules=%40vue%2Fcomposition-api%2C%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%2CsearchVue%2Cvue%2Cvuex%7Cext.advancedSearch.elements%2Cinit%2Cstyles%7Cext.cirrus.serp%7Cjquery.highlightText%2Csuggestions%7Cmediawiki.searchSuggest%2Cwidgets%7Cmediawiki.special.search%7Cmediawiki.special.search.commonsInterwikiWidget%7Cmediawiki.widgets.SearchInputWidget%7Coojs-ui-widgets.icons%7Coojs-ui.styles.icons-content%2Cicons-editing-advanced%2Cicons-interactions%2Cicons-layout&skin=minerva&version=13zfi:128:881

Event Timeline

Change 921046 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/SearchVue@master] Cannot read properties of null (reading 'getAttribute')

https://gerrit.wikimedia.org/r/921046

Change 921046 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] Cannot read properties of null (reading 'getAttribute')

https://gerrit.wikimedia.org/r/921046

Etonkovidova subscribed.

No errors have been recorded for wmf.11 - see logstash link. Last timestamp - Jun 1, 2023 @ 17:11:27.848 for group 2 wmf.10 wikis.