Page MenuHomePhabricator

Debug Error: Hash check request failed
Closed, InvalidPublic

Description

Closing as a duplicate of https://phabricator.wikimedia.org/T336205

It seems our hashing is not working as intended. We throw a DEBUG error here - it doesn't stop us from uploading but we get an error back from PhotoDNA as well (see this ticket).

So we should:

  1. fix the hashing
  2. if we hit this error, send as a photo instead of a hash
2023-05-08 20:34:50.544354 [2bbe3e98516c8a8029072258] mw1458 commonswiki 1.41.0-wmf.7 mediamoderation DEBUG: Hash check request failed for file Bieraście,_Pahonia._Берасьце,
_Пагоня_(1789)_(2).jpg. {"file":"Bieraście,_Pahonia._Берасьце,_Пагоня_(1789)_(2).jpg"}

Event Timeline

From my reading of the code:

  • the debug message ("Hash check request failed") comes from a failed CheckResultValue in the call to RequestModerationCheck::requestModeration
  • requestModeration is creating a payload with the URL for the file (createModerationRequest), and not the file itself. (That means PhotoDNA needs to make a request back to MediaWiki. I saw some discussion in another task about whether it would be preferable to just transmit the file -- that way we avoid issues like Commons not responding to the PhotoDNA request for whatever reason.)
  • Looking at the logs for that requestId, the error is T336205: Debug Error: The given file could not be verified as an image

So, I think we could close this as a duplicate of T336205: Debug Error: The given file could not be verified as an image?

my understanding, and granted it seems a lot of the information I was given seems to be a bit off, was that we were sending hash strings to PhotoDNA, so now I am totally gonna have to go back and review what I thought I knew.

JKieserman updated the task description. (Show Details)