Page MenuHomePhabricator

Personalized praise includes users with homepage disabled
Closed, ResolvedPublic

Description

Filling based on a report of a Czech Wikipedia mentor.

The Personalized praise module of the Mentor dashboard recommends the mentor users they can praise. While the module takes into account whether the mentorship module is enabled or not, it does not appear to take into account whether the homepage itself is enabled. This should be fixed, as users without the Homepage enabled shouldn't be exposed to Growth mentorship using our features.

Acceptance criteria
  • When a mentor is assigned to a user with Special:Homepage disabled, the user does not appear in the Personalized praise module regardless of their amount of edits.

Event Timeline

Change 917936 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Personalized praise: Do not suggest users with Homepage disabled

https://gerrit.wikimedia.org/r/917936

Change 917936 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Personalized praise: Do not suggest users with Homepage disabled

https://gerrit.wikimedia.org/r/917936

Change 919175 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.41.0-wmf.8] Personalized praise: Do not suggest users with Homepage disabled

https://gerrit.wikimedia.org/r/919175

Change 919176 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.41.0-wmf.7] Personalized praise: Do not suggest users with Homepage disabled

https://gerrit.wikimedia.org/r/919176

Change 919175 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.41.0-wmf.8] Personalized praise: Do not suggest users with Homepage disabled

https://gerrit.wikimedia.org/r/919175

Change 919176 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.41.0-wmf.7] Personalized praise: Do not suggest users with Homepage disabled

https://gerrit.wikimedia.org/r/919176

Mentioned in SAL (#wikimedia-operations) [2023-05-11T20:51:11Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:919175|Personalized praise: Do not suggest users with Homepage disabled (T336300)]], [[gerrit:919176|Personalized praise: Do not suggest users with Homepage disabled (T336300)]]

Mentioned in SAL (#wikimedia-operations) [2023-05-11T20:52:42Z] <urbanecm@deploy1002> urbanecm: Backport for [[gerrit:919175|Personalized praise: Do not suggest users with Homepage disabled (T336300)]], [[gerrit:919176|Personalized praise: Do not suggest users with Homepage disabled (T336300)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-05-11T20:58:41Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:919175|Personalized praise: Do not suggest users with Homepage disabled (T336300)]], [[gerrit:919176|Personalized praise: Do not suggest users with Homepage disabled (T336300)]] (duration: 07m 30s)

Etonkovidova subscribed.

Checked on testwiki wmf.17 - works as per the task spec: users with disabled Homepage won't be shown in Personalized Praise module.

Notes:

  • Users with disabled Homepage won't be shown in Your mentees table
  • Users with disabled Homepage are still associated with their mentors (I checked it with growthmentormentee&gemmmentor=Zilant17). When a user enables Home page, the same mentor will be re-assigned.