Page MenuHomePhabricator

Visual diff always marks changed-and-moved elements as moved down, even when moved up
Closed, ResolvedPublic

Description

Visual diff always marks changed-and-moved elements as moved down, even when moved up.

For example, in this diff, the category was clearly moved up (and changed): https://en.wikipedia.org/w/index.php?diff=1154027287

image.png (2×3 px, 642 KB)

But the visual diff says it was moved down:

image.png (2×3 px, 974 KB)


In this diff, the list item was moved up and changed: https://en.wikipedia.beta.wmflabs.org/w/index.php?diff=585078

image.png (2×3 px, 446 KB)

But the visual diff says it was moved down:

image.png (2×3 px, 430 KB)

Event Timeline

matmarex renamed this task from Visual diff always marks moved categories as moved down, even when moved up to Visual diff always marks changed-and-moved elements as moved down, even when moved up.May 9 2023, 10:45 PM
matmarex updated the task description. (Show Details)

Change 917964 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[VisualEditor/VisualEditor@master] Fix diff move labels for changed-and-moved nodes

https://gerrit.wikimedia.org/r/917964

We should also make category items incomparable. Although I'm sure some on-page category edits are typo fixes, because of the way categories work, you are always removing a page from one category and inserting it into another.

Change 917964 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Fix diff move labels for changed-and-moved nodes

https://gerrit.wikimedia.org/r/917964

Change 924505 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Never compare different categories

https://gerrit.wikimedia.org/r/924505

Change 924505 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Never compare different categories

https://gerrit.wikimedia.org/r/924505

Change 925083 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (d463fbd15)

https://gerrit.wikimedia.org/r/925083

Change 925083 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (d463fbd15)

https://gerrit.wikimedia.org/r/925083