We don't have a way of disabling image recommendations for the frontend only, the way we do for link recommendations. If GENewcomerTasksImageRecommendationsEnabled is true, image recommendations show up in the task type selector. If it is false, the ConfigurationLoader doesn't return the image recommendation task type, even if it is defined in the JSON.

I can think of two ways to handle it:

1. Add a GENewcomerTasksImageRecommendationsFrontendEnabled flag (or maybe generalize this to a way to enable / disable the frontend for any task type separately). Audit the current usage of GENewcomerTasksImageRecommendationsEnabled and replace some of it with the new flag, so it prevents the submission handler from working but not the configuration loader, and that it prevents the frontend-disabled task type from showing up in the task type selector (via NewcomerTasksUserOptionsLookup / TaskTypesAbFilter, presumably).
2. Replace the call to the configuration loader in ApiQueryImageSuggestionData with some hard-coded task types. The details of the tasktype objects don't really matter, only their ID is used. Fix AddImageSubmissionHandler::invalidateRecommendation() to receive the tasktype as an argument instead of calling the configuration loader - we probably need to do this anyway.

The first is the safe & clean option, the second is the quick & dirty one. Once one of those gets done, we can just add an image recommendation tasktype to the JSON of every wiki, and the API should work, I think.

In T336358#8840423, @Tgr wrote:

We don't have a way of disabling image recommendations for the frontend only, the way we do for link recommendations. If GENewcomerTasksImageRecommendationsEnabled is true, image recommendations show up in the task type selector. If it is false, the ConfigurationLoader doesn't return the image recommendation task type, even if it is defined in the JSON.

I can think of two ways to handle it:

1. Add a GENewcomerTasksImageRecommendationsFrontendEnabled flag (or maybe generalize this to a way to enable / disable the frontend for any task type separately). Audit the current usage of GENewcomerTasksImageRecommendationsEnabled and replace some of it with the new flag, so it prevents the submission handler from working but not the configuration loader, and that it prevents the frontend-disabled task type from showing up in the task type selector (via NewcomerTasksUserOptionsLookup / TaskTypesAbFilter, presumably).
2. Replace the call to the configuration loader in ApiQueryImageSuggestionData with some hard-coded task types. The details of the tasktype objects don't really matter, only their ID is used. Fix AddImageSubmissionHandler::invalidateRecommendation() to receive the tasktype as an argument instead of calling the configuration loader - we probably need to do this anyway.

The first is the safe & clean option, the second is the quick & dirty one. Once one of those gets done, we can just add an image recommendation tasktype to the JSON of every wiki, and the API should work, I think.

Thanks for writing this out. Option 1 sounds like the better one to me.

Adding our team for awareness, thanks for doing this

@JTannerWMF When do you think the app team will need this finished?

Change 919812 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Allow some interactions with disabled task types

https://gerrit.wikimedia.org/r/919812

Change 919812 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Allow some interactions with disabled task types

https://gerrit.wikimedia.org/r/919812