AQS 2.0: Edit Analytics: Implement integration tests
Open, MediumPublic
Actions

Assigned To

Authored By

	BPirkle
	May 10 2023, 1:49 PM

Description

subtask. of epic T327817

Details

	Project	Branch	Lines +/-	Subject
	generated-data-platform/aqs/edit-analytics	main	+1 K -15	Tests and minify

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Stalled	None	T324931 Clean up open RESTBase related tickets
In Progress	None	T262315 <CORE TECHNOLOGY> API Migration & RESTbase Sunset
In Progress	DAbad	T263489 AQS 2.0
Open	None	T327817 Edit Analytics Service
Open	EChukwukere-WMF	T336394 AQS 2.0: Edit Analytics: Implement integration tests

Event Timeline

BPirkle created this task.May 10 2023, 1:49 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 10 2023, 1:49 PM

BPirkle added a parent task: T327817: Edit Analytics Service.May 10 2023, 1:49 PM

See T327836: AQS 2.0: Edit Analytics: Implement Unit Tests

JArguello-WMF edited projects, added AQS2.0 (Sprint 10); removed API Platform (AQS 2.0 Roadmap).Jun 8 2023, 11:59 AM

JArguello-WMF updated the task description. (Show Details)

JArguello-WMF added subscribers: VirginiaPoundstone, SGupta-WMF, Sfaci and 3 others.

JArguello-WMF renamed this task from Edit Analytics: Integration tests to Edit Analytics: unit tests.Jun 8 2023, 12:02 PM

JArguello-WMF renamed this task from Edit Analytics: unit tests to Edit Analytics: integration tests.

JArguello-WMF mentioned this in T327817: Edit Analytics Service.Jun 8 2023, 12:07 PM

Sfaci renamed this task from Edit Analytics: integration tests to Edit Analytics: Implement integration tests.Jul 4 2023, 9:36 AM

Sfaci renamed this task from Edit Analytics: Implement integration tests to AQS 2.0: Edit Analytics: Implement integration tests.Jul 17 2023, 9:46 AM

Sfaci claimed this task.

Sfaci triaged this task as Medium priority.

Sfaci removed Sfaci as the assignee of this task.Jul 19 2023, 7:33 AM

SGupta-WMF claimed this task.Wed, Sep 6, 9:46 AM

SGupta-WMF added a project: Data Products (Sprint 00).

SGupta-WMF moved this task from Sprint Backlog to In Process on the Data Products (Sprint 00) board.

Sfaci edited projects, added Data Products (Sprint 01); removed Data Products (Sprint 00), AQS2.0 (Sprint 10).Tue, Sep 12, 2:02 PM

Sfaci moved this task from Sprint Backlog to In Process on the Data Products (Sprint 01) board.

Change 958461 had a related patch set uploaded (by Sg912; author: Sg912):

[generated-data-platform/aqs/edit-analytics@main] Tests and minify

https://gerrit.wikimedia.org/r/958461

gerritbot added a project: Patch-For-Review.Mon, Sep 18, 11:53 AM

SGupta-WMF reassigned this task from SGupta-WMF to Sfaci.Mon, Sep 18, 11:54 AM

SGupta-WMF moved this task from In Process to Ready for Code Review on the Data Products (Sprint 01) board.

Sfaci moved this task from Ready for Code Review to In code review / Tech Input on the Data Products (Sprint 01) board.Tue, Sep 19, 10:29 AM

SGupta-WMF moved this task from In code review / Tech Input to Paused on the Data Products (Sprint 01) board.Tue, Sep 19, 12:17 PM

Sfaci moved this task from Paused to In code review / Tech Input on the Data Products (Sprint 01) board.Tue, Sep 19, 4:07 PM

Just a warning for our future selfs about these integration test cases and some improvements we added to the common Druid code that are no present here yet. Real support for 'all-projects' and 'all-wikipedia-projects' keywords was added there but we still need to refactor this service to take advantage of it. Because of that, at the time of writing this, that is not really working because these keywords are validated as a regular project value and no data is found.

So, until refactoring is done, we can consider some tests values as fine but we will have to keep in mind that some of them will change after refactoring using the common Druid code. We will have to keep specially in mind all tests cases that use those keywords. Maybe we should keep this ticket open to be revisited after refactoring.

Another issue should be considered after refactoring. The one about 404 vs 200 with zero values when no data is found regarding the project. There are no consistency between this services and the rest of them and recently we discussed about keeping the 404 Not Found error when no data is found for that reason. Some endpoints at this moment respond with a 200 and zero values and some others with a 404 Not Found error.

Sfaci mentioned this in T344374: AQS 2.0 Druid-based services: Explore how to run QA test suite using Docker.Wed, Sep 20, 9:07 AM

Change 958461 merged by Sg912:

[generated-data-platform/aqs/edit-analytics@main] Tests and minify

https://gerrit.wikimedia.org/r/958461

SGupta-WMF reassigned this task from Sfaci to EChukwukere-WMF.Mon, Sep 25, 11:08 AM

SGupta-WMF moved this task from In code review / Tech Input to Ready for Testing on the Data Products (Sprint 01) board.

Maintenance_bot removed a project: Patch-For-Review.Mon, Sep 25, 11:10 AM