Regression: __NOEDITSECTION__ is ignored when the page is read from the parser cache
Closed, ResolvedPublic

Assigned To
Unbreak Now!
brion, Anomie, tstarling and 3 others

Patch to have ParserCache check for NOEDITSECTION

After the fix for bug 31445, NOEDITSECTION is now ignored when the page is loaded from the parser cache.

The problem seems to be that ParserCache's get() is not taking into account the possibility of NOEDITSECTION when calling ParserOutput's setEditSectionTokens().

An easy patch is attached, although it may not be the best way to do it.

Version: 1.20.x
Severity: normal

Attached: diff

bzimport added a project: MediaWiki-Page-editing.Via ConduitNov 21 2014, 11:54 PM
bzimport added a subscriber: wikibugs-l.
bzimport set Reference to bz31647.
Anomie created this task.Via LegacyOct 12 2011, 4:12 PM
Platonides added a comment.Via ConduitOct 25 2011, 10:20 PM

I see. the parser, which is the entity knowing about NOEDITSECTION, is no longer run there, so it doesn't come to decide on it and the default (ie. without taking NOEDITSECTION into account) is used. Still, I don't think that logic should be in ParserCache.

Should be fixed in r100756.

Add Comment

Column Prototype
This is a very early prototype of a persistent column. It is not expected to work yet, and leaving it open will activate other new features which will break things. Press "\" (backslash) on your keyboard to close it now.