| dom_walden | |
| May 11 2023, 10:35 AM |
| F37006487: T336481_BetterDiffs_Vector2010_HelpButton.png | |
| May 17 2023, 10:10 PM |
| F37006505: T336481_BetterDiffs_JsonConfig_Legend.png | |
| May 17 2023, 10:10 PM |
| F37006499: T336481_BetterDiffs_DiffofSuppress_InvalidError.png | |
| May 17 2023, 10:10 PM |
| F37006468: T336481_BetterDiffs_Vector2022_TitleAlignment_LoggedOut.png | |
| May 17 2023, 10:10 PM |
| F37006465: T336481_BetterDiffs_Vector2022_TitleAlignment.png | |
| May 17 2023, 10:10 PM |
| F36992077: proofreadpage_legend_bug.png | |
| May 11 2023, 10:35 AM |
If you look at a ProofreadPage diff with diff-type=inline you see the new legend as implemented in T324759.
Wiki(s): https://en.wikisource.beta.wmflabs.org MediaWiki 1.41.0-alpha (fc89c57) 08:04, 11 May 2023. VisualEditor 0.1.2 (1810eca) 07:21, 11 May 2023.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Samwilson | T324759 Inline Diff: Add legend and tooltips | |||
| Invalid | BUG REPORT | Samwilson | T336481 Legend appears in ProofreadPage diffs |
Change 920393 had a related patch set uploaded (by Samwilson; author: Samwilson):
[mediawiki/core@master] diff: Only show inline legend for text slot
Change 920393 merged by jenkins-bot:
[mediawiki/core@master] diff: Only show inline legend for text slot
Change 920578 had a related patch set uploaded (by Samtar; author: Samwilson):
[mediawiki/core@wmf/1.41.0-wmf.9] diff: Only show inline legend for text slot
@Samwilson Please see the findings below. Diff of suppressed revisions and JsonConfig both came from the Diff Type link below.
OS: macOS 13.3
Browsers: Chrome 113, Firefox 113, Safari 16.4
Skins: Vector 2022, 2010, Minerva, Monobook, Timeless
Test Link: https://en.wikisource.beta.wmflabs.org/w/index.php?title=Page%3AWar_and_Peace.djvu%2F22&diff=10182&oldid=5001&diff-type=inline
Also Diff types from: - https://meta.wikimedia.org/wiki/Community_Wishlist_Survey_2022/Better_diff_handling_of_paragraph_splits/Test_strategy/Types_of_diffs
Vector 2022- When logged in, I was getting a spacing issue on the title for this link (https://en.wikisource.beta.wmflabs.org/w/index.php?title=Page%3AWar_and_Peace.djvu%2F22&diff=10182&oldid=5001&diff-type=inline). All the other skins, I did not have an issue with it. When I was logged out though, the title was fine.
UPDATE 5/18: Seems like the patch got reverted and I no longer receiving this issue with the title spacing.
| Skin | Logged in | Logged out |
| Vector2022 |  |  |
Diff of suppressed revisions- Trying to switch to Visual but I'm getting an Invalid response from server error
JsonConfig- Legend is showing even though I have diff-type=inline
Opinion 1 - Under Vector 2022, should the Help button be on the title line alongside with Add Language, to make it look cleaner? It seems like all the other skins have the Help button on the title line too except for Vector 2022.
| Info | Vector 2010 | Vector 2022 |
| Help Button |  | |
Change 920578 abandoned by Samtar:
[mediawiki/core@wmf/1.41.0-wmf.9] diff: Only show inline legend for text slot
Reason:
Not backporting
New implementation will cover the issue described in this task. Please see https://phabricator.wikimedia.org/T324759#8874993