Page MenuHomePhabricator

Card: fix border color
Closed, ResolvedPublic1 Estimated Story Points

Description

Background

Card is correctly using border-color-base in the Codex demo, while the Figma specs apply border-color-subtle.

image.png (258×1 px, 24 KB)
image.png (374×1 px, 22 KB)
Codex demoFigma spec

Design spec

Open questions

Add here the questions to be answered in order to design and implement the component

Acceptance criteria (or Done)

  • Fix the Card's border color in Figma to match demo

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
ldelench_wmf subscribed.

Hi @AAlhazwani-WMF , thanks for reporting this - the Design Systems Team will review this by 2023-05-17 and let you know what to expect.

Hi @AAlhazwani-WMF! The Card component demo is actually displaying the correct border color (border-color-base). Unfortunately, the specs weren't updated to reflect that design decision that searched to ensure better contrast. I'll correct that right now in both the exploration file (a new v7 of the component will be added) and the component library. Thanks so much for the catch!

Thanks Sarai! Do you mind updating the acceptance criteria as needed?

Restricted Application triaged this task as High priority. · View Herald TranscriptMay 15 2023, 4:38 PM
Volker_E set the point value for this task to 1.May 15 2023, 4:43 PM