Page MenuHomePhabricator

Usernames in Special:MergeHistory using MinervaNeue skin are not crossed out when the username is deleted or suppressed
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Make sure you have 2 pages created in your Local
  • Go to the page history or log page where the temporary account username is shown.
  • Check the box next to the revision or log entry that you want to delete.
  • Click the Change visibility of selected revisions button at the top of the page.
  • Choose which parts of the revision or log entry you want to hide: the revision text, the edit summary, or the editor’s username/IP address.
  • Optionally, check the box to hide the information from administrators as well (if you have the suppress revision right).
  • Enter a reason for hiding the information in the box provided.
  • Click Apply to selected revision(s).
  • Switch to the Minerva skin in preferences
  • Go to the Special: MergeHistory page
  • Enter the Source Page and Destination Page names
  • Click on Show Mergeable Edits button.

What happens?:
The issue is that ex. *Unregistered 22 and *Unregistered 21 are not crossed out like the other skins. Only in Special:MergeHistory, not View History. It's still showing as unmarked.

What should have happened instead?:
Temp users should be crossed out too under the Minerva skin.

Other information (browser name/version, screenshots, etc.):

Minerva- Temp users are not crossed out in Special:MergeHistory

Minerva Skin
T330964_IPMasking_ShowIP_NotItalicised_MinervaMerge.png (1×1 px, 136 KB)
T330964_IPMasking_ShowIP_NotItalicised_MinervaHistory.png (758×1 px, 155 KB)

Vector- Same example on a different skin but the correct way

Vector Skin
T330964_IPMasking_ShowIP_NotItalicised_DeleteHistory.png (509×1 px, 166 KB)
T330964_IPMasking_ShowIP_NotItalicised_DeleteMerge.png (655×3 px, 202 KB)

Event Timeline

Umherirrender subscribed.

Styles are part of mediawiki.interface.helpers.styles in core, but minerva overrides it with skin styles, so nothing the extension or core can do about.

@GMiksell-WMF Was this a pre-existing problem?

Dreamy_Jazz renamed this task from Special: MergeHistory is now displaying the cross outs when a temp user is deleted or suppressed to Temporary account usernames in Special: MergeHistory are not crossed out when the username is deleted or suppressed.May 16 2023, 12:51 PM
Dreamy_Jazz renamed this task from Temporary account usernames in Special: MergeHistory are not crossed out when the username is deleted or suppressed to Temporary account usernames in Special:MergeHistory using MinervaNeue skin are not crossed out when the username is deleted or suppressed.

On hindsight, I think putting the mw-tempuserlink rule inside mediawiki.interface.helpers.styles was a mistake on our part. mediawiki.interface.helpers.styles was intended for allowing skins control over the entire interface layout. If the goal is consistent styles for IP masked users across all skins, mediawiki.interface.helpers.styles was the wrong choice here and it would be better to put the rule inside mediawiki.special and mediawiki.action.styles.

Minerva certainly shouldn't be rewriting this rule itself.

Change 920315 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Move temporary user mixin out of interface.helpers

https://gerrit.wikimedia.org/r/920315

The uploaded patch cleans up the use of the right CSS files but does not cross the "username removed" part of the log which is the purpose of this ticket.
Also, the Show IP button is no longer appearing despite being logged in as an Admin with rights (it shows on branch Master)

Screenshot 2023-05-23 at 11.45.17 AM.png (646×1 px, 113 KB)

Should we dissociate this patch from this task and go forward with it while we create another patch for this specific task?

Tchanders renamed this task from Temporary account usernames in Special:MergeHistory using MinervaNeue skin are not crossed out when the username is deleted or suppressed to Usernames in Special:MergeHistory using MinervaNeue skin are not crossed out when the username is deleted or suppressed.May 24 2023, 5:31 PM

This isn't specific to temporary users - it occurs for IP users and named users too:

VectorMinerva
image.png (314×1 px, 100 KB)
image.png (369×1 px, 109 KB)

I also double-checked that it predates any changes we made in T330964 (which is what was being tested when @GMikesell-WMF found this bug).

Should we dissociate this patch from this task and go forward with it while we create another patch for this specific task?

I think that's a good idea. I've also untagged IP Masking from this task, as it appears unrelated (see previous comment).

Change 928953 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Do not use skin styles for rules that should never be overriden

https://gerrit.wikimedia.org/r/928953

Change 928960 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] resources: Split styles in module mediawiki.interface.helpers.styles

https://gerrit.wikimedia.org/r/928960

Change 928953 abandoned by Jdlrobson:

[mediawiki/core@master] Move non-overrideable styles out of skin styles

Reason:

More complete version in https://gerrit.wikimedia.org/r/928960

https://gerrit.wikimedia.org/r/928953

Change 928960 merged by jenkins-bot:

[mediawiki/core@master] resources: Split styles in module mediawiki.interface.helpers.styles

https://gerrit.wikimedia.org/r/928960

Change 928960 merged by jenkins-bot:

[mediawiki/core@master] resources: Split styles in module mediawiki.interface.helpers.styles

https://gerrit.wikimedia.org/r/928960

With this patch set all places where revision-deleted content is shown should now also styled in minerva, not only on Special:MergeHistory

Change 920315 abandoned by Jdlrobson:

[mediawiki/core@master] Move temporary user mixin out of interface.helpers

Reason:

Resolved in https://gerrit.wikimedia.org/r/q/I11c54b58873523f7b72cca67b82efdd681562508

https://gerrit.wikimedia.org/r/920315

This should be fixed now. @GMikesell-WMF would your team like to take a pass at QA or can this be resolved?

@Jdlrobson Thanks - I'm happy to resolve this if you are.

Jdlrobson claimed this task.