@AnneT would there be any work on the DST side as part of this ticket? I see that you're currently assigned. I'm wondering if we should move it to Following or if we need to take this through refinement.

Note: As soon as we would swap that out we will have to live with the font-sizes of the default theme over the base font-size optimized legacy ones. In a mixed base size interface we'd have more issues scaling down than up from my experience.

Change 925019 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] POC: Use default codex theme

https://gerrit.wikimedia.org/r/925019

Try using the wikimedia-ui Codex theme in Vector and evaluate the results, especially for TypeaheadSearch. To do this, replace the line here: https://gerrit.wikimedia.org/g/mediawiki/skins/Vector/+/784fa9a13523f894fc6ee4487c900cd17d65d33d/resources/mediawiki.less/vector-2022/mediawiki.skin.variables.less#19 with an import for theme-wikimedia-ui.less.

Making the 1 line change described here seems pretty easy, running pixel on that change doesnt show any changes. I also ran pixel with this change on the work that uses Codex styles for the buttons and search.

However, the reason for this is that we are overriding theme variables like @font-size-base in common/variables.less, meaning we weren't really relying on the Codex theme and tokens to begin with. The larger issue is that are using @font-size-base instead of @font-size-small. We probably shouldn't switch those variables right now though, because we want to increase the default font size with the font size preference anyway, that work might allow us to stop overriding @font-size-base

I also noticed that the adoption of Codex button styles seems to have reduced font size issues for the icons/buttons in Vector, so theres some nice CSS clean up that we can do around font sizes.

In short, we *could* easily import the default theme right now, but that wouldnt really do anything because we are overriding it anyway. Instead, I'd suggest a new task that handles importing the default theme, removing as many overrides as possible, and cleaning up misc font size related CSS. This new task might be blocked on the font size preference work.

Change 925019 abandoned by Bernard Wang:

[mediawiki/skins/Vector@master] POC: Use default codex theme

Reason:

https://gerrit.wikimedia.org/r/925019

In short, we *could* easily import the default theme right now, but that wouldnt really do anything because we are overriding it anyway. Instead, I'd suggest a new task that handles importing the default theme, removing as many overrides as possible, and cleaning up misc font size related CSS. This new task might be blocked on the font size preference work.

@bwang I think that might be worth it, just as it makes clear that the web team has ownership of this issue. While it's there, it gives the design team the impression that it's being used and they have to maintain it with every release. Would you have any concerns with us doing that one line change now?

I'd suggest a new task that handles importing the default theme, removing as many overrides as possible, and cleaning up misc font size related CSS. This new task might be blocked on the font size preference work.

but yes I agree we should do this! Could you set one up?

@Jdlrobson I dont see any issue with doing the one line change now. Heres the new task T338979

Change 929805 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Use the standardized Codex design tokens

https://gerrit.wikimedia.org/r/929805

Change 929805 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Use the standardized Codex design tokens

https://gerrit.wikimedia.org/r/929805