Bank dropdown spacing issues
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Pcoombe
	May 12 2023, 2:27 PM

Description

A minor thing I noticed on the new Adyen Czech bank transfer forms: there is no space between the Email input and the dropdown on mobile. There should be space above it like on desktop - in fact maybe the space on desktop too should be increased to make it match the rest of the form.

The same is true on the NL iDeal form, I don't know if there's any more using a similar dropdown.

Mobile:

Screenshot_20230512-150917.png (2×1 px, 183 KB)

Desktop:

Screenshot 2023-05-12 at 15.25.16.png (1×1 px, 81 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Fix bank dropdown spacing issue	mediawiki/extensions/DonationInterface	master	+1 -1

Customize query in gerrit

Event Timeline

Pcoombe created this task.May 12 2023, 2:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 12 2023, 2:27 PM

AKanji-WMF moved this task from Triage to DRI Backlog on the Fundraising-Backlog board.May 15 2023, 8:30 PM

Damilare claimed this task.May 16 2023, 11:59 AM

Damilare added a project: Fundraising Tech - Chaos Crew.

Damilare moved this task from Backlog to In Progress on the Fundraising Tech - Chaos Crew board.

Change 920297 had a related patch set uploaded (by Damilare Adedoyin; author: Damilare Adedoyin):

[mediawiki/extensions/DonationInterface@master] Fix bank dropdown spacing issues

https://gerrit.wikimedia.org/r/920297

gerritbot added a project: Patch-For-Review.May 16 2023, 2:39 PM

Damilare moved this task from In Progress to Ready for Review on the Fundraising Tech - Chaos Crew board.May 16 2023, 2:40 PM

Change 920297 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Fix bank dropdown spacing issue

https://gerrit.wikimedia.org/r/920297

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 17 2023, 3:00 PM

Damilare moved this task from Ready for Review to Pending Deployment on the Fundraising Tech - Chaos Crew board.May 17 2023, 3:04 PM

Maintenance_bot removed a project: Patch-For-Review.May 17 2023, 3:10 PM

With Dami's patch deployed we get some space above it on mobile - no change to the spacing on desktop though. And I notice the bottom of the box looks a little glitchy: