Page MenuHomePhabricator
Create Task
Maniphest T336582

Disable visual diffs in Special:AbuseFilter diffs
Closed, InvalidPublic2 Estimated Story PointsBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?: server returns error

What should have happened instead?: In the first place, it should not be possible to change

Software version (skip for WMF-hosted wikis like Wikipedia): WMF-hosted

Other information (browser name/version, screenshots, etc.):

Details

SubjectRepoBranchLines +/-
onDifferenceEngineBeforeDiffTable: Return early on Special pagesmediawiki/extensions/VisualEditormaster+1 -1
onDifferenceEngineBeforeDiffTable: Update commentmediawiki/extensions/VisualEditormaster+2 -1
onDifferenceEngineBeforeDiffTable: Return early on Special pagesmediawiki/extensions/VisualEditorwmf/1.41.0-wmf.9+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Syunsyunminmin created this task.May 12 2023, 2:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 12 2023, 2:56 PM
Maintenance_bot added a project: VisualEditor.May 12 2023, 3:29 PM
matmarex added a project: Community-Tech.May 12 2023, 7:32 PM
matmarex added subscribers: Samwilson, HMonroy, MusikAnimal.
matmarex subscribed.

(Probably caused by the work on T324759)

dom_walden subscribed.May 15 2023, 9:35 AM

Thanks for bringing this to our attention.

I also see the same issue happen when looking at details of a triggered filter: https://en.wikipedia.beta.wmflabs.org/wiki/Special:AbuseLog/333452

TheresNoTime edited projects, added Community-Tech (CommTech-Kanban); removed Community-Tech.May 16 2023, 10:21 AM
TheresNoTime claimed this task.May 16 2023, 10:43 AM
TheresNoTime moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Kanban) board.
gerritbot added a comment.May 16 2023, 11:40 AM

Change 920252 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/extensions/VisualEditor@master] onDifferenceEngineBeforeDiffTable: Return early on Special pages

https://gerrit.wikimedia.org/r/920252

gerritbot added a project: Patch-For-Review.May 16 2023, 11:40 AM
TheresNoTime moved this task from In Development 💻 to Review/Feedback 💬 on the Community-Tech (CommTech-Kanban) board.May 16 2023, 11:55 AM
TheresNoTime added a parent task: T324759: Inline Diff: Add legend and tooltips.
KSiebert set the point value for this task to 2.May 16 2023, 1:06 PM
TheresNoTime moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Kanban) board.May 16 2023, 1:10 PM
gerritbot added a comment.May 16 2023, 1:38 PM

Change 920252 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] onDifferenceEngineBeforeDiffTable: Return early on Special pages

https://gerrit.wikimedia.org/r/920252

Maintenance_bot removed a project: Patch-For-Review.May 16 2023, 2:10 PM
gerritbot added a comment.May 16 2023, 5:33 PM

Change 920356 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/extensions/VisualEditor@master] onDifferenceEngineBeforeDiffTable: Update comment

https://gerrit.wikimedia.org/r/920356

gerritbot added a project: Patch-For-Review.May 16 2023, 5:33 PM
gerritbot added a comment.May 16 2023, 6:36 PM

Change 920356 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] onDifferenceEngineBeforeDiffTable: Update comment

https://gerrit.wikimedia.org/r/920356

Maintenance_bot removed a project: Patch-For-Review.May 16 2023, 7:10 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 16 2023, 11:01 PM
gerritbot added a comment.May 17 2023, 9:26 AM

Change 920579 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/extensions/VisualEditor@wmf/1.41.0-wmf.9] onDifferenceEngineBeforeDiffTable: Return early on Special pages

https://gerrit.wikimedia.org/r/920579

gerritbot added a project: Patch-For-Review.May 17 2023, 9:26 AM
gerritbot added a comment.May 18 2023, 3:00 PM

Change 920579 abandoned by Samtar:

[mediawiki/extensions/VisualEditor@wmf/1.41.0-wmf.9] onDifferenceEngineBeforeDiffTable: Return early on Special pages

Reason:

Not backporting

https://gerrit.wikimedia.org/r/920579

Maintenance_bot removed a project: Patch-For-Review.May 18 2023, 3:10 PM
TheresNoTime changed the task status from Open to Stalled.May 18 2023, 5:13 PM
TheresNoTime moved this task from QA 🐛 to Needs Attention 👀 on the Community-Tech (CommTech-Kanban) board.

Stalled — patches reverted, implementation changing

HMonroy mentioned this in T324759: Inline Diff: Add legend and tooltips.May 23 2023, 9:42 PM
HMonroy closed this task as Invalid.May 23 2023, 9:50 PM

New implementation will cover the issue described in this task. Please see https://phabricator.wikimedia.org/T324759#8874993

MusikAnimal moved this task from Needs Attention 👀 to Done 🏁 on the Community-Tech (CommTech-Kanban) board.Wed, Apr 10, 4:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL