Page MenuHomePhabricator

Fullscreen map offset calculation inaccurate
Closed, ResolvedPublicBUG REPORT

Description

When a map is opened to the full screen view there's an offset applied to the center point of the map that's supposed to adjust the viewport of the map when the footer or sidebar overlap the view. This offset is/was responsible for at least two problems that became more visible with the flexible footer calculation and the fact that the footer can have an almost arbitrary height ( T333160: On narrow screens "External maps" footer button vanishes ):

Event Timeline

Change 919287 had a related patch set uploaded (by WMDE-Fisch; author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Remove bogus fullscreen map footer offset calculation

https://gerrit.wikimedia.org/r/919287

Change 919328 had a related patch set uploaded (by WMDE-Fisch; author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] [POC] Fix fullscreen map jumping on open in static mode

https://gerrit.wikimedia.org/r/919328

Change 919328 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Kartographer@master] [POC] Fix fullscreen map jumping on open in static mode

Reason:

Replaced with I45a1954.

https://gerrit.wikimedia.org/r/919328

Change 919287 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Remove bogus fullscreen map footer offset calculation

https://gerrit.wikimedia.org/r/919287

WMDE-Fisch removed WMDE-Fisch as the assignee of this task.

( all deployed now )