Page MenuHomePhabricator

A certain text substitution does not work (e.g. in Enotif message text)
Closed, ResolvedPublic

Description

Using E-mail notification http://bugzilla.wikipedia.org/show_bug.cgi?id=454 of
CVS HEAD of today, ENotif e-mails are sent out which are not correctly composed
(in a certain line), see

example of a WRONG ENOTIF MAIL:
"...See
http://myserver/phase3/index.php?title=%24PAGETITLE_RAWURL&diff=0&oldid=$OLDID
for all changes since "

Solution:

A two-level string substitution is needed, which were lost by the CVS commit in
December.

TO FIX THIS, please change in UserMailer.php (add one line)

  1. regarding the use of oldid as an indicator for the last visited version, see also
    1. http://bugzilla.wikipeda.org/show_bug.cgi?id=603 "Delete + undelete cycle

doesn't preserve old_id"

  1. However, in the case of a new page which is already watched, we have no

previous version to compare

		if( $article->mOldid ) {
			$keys['$NEWPAGE'] = wfMsg( 'email_notification_lastvisitedrevisiontext' );
			$keys['$OLDID']   = $article->mOldid;
		} else {
			$keys['$NEWPAGE'] = wfMsg( 'email_notification_newpagetext' );
			# clear $OLDID placeholder in the message template
			$keys['$OLDID']   = '';
		}

LINE 271:

		$body = strtr( $body, $keys );  // <<<<<---- ADD THIS HERE

		$pagetitle = $article->mTitle;

Please can anyone of the core developers add the indicated line in
UserMailer.php , thanks

Tom aka Wikinaut

  • for ENotif

Version: 1.5.x
Severity: normal
URL: http://meta.wikipedia.org/Enotif

Details

Reference
bz1366
TitleReferenceAuthorSource BranchDest Branch
jenkins-rel: updating plugin versions to address vulnerabilitiesrepos/releng/jenkins-deploy!28jnucheupdate-pluginsmaster
Customize query in GitLab

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:11 PM
bzimport set Reference to bz1366.