Page MenuHomePhabricator

Dragging toolbar then zooming in can cause the toolbar to fall off the screen
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Be a patroller
  • Open an unreviewed article
  • Drag the toolbar a bit
  • Zoom your browser in a lot

What happens?:

  • Toolbar goes completely off the screen

What should have happened instead?:

  • Toolbar should stay on the screen

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

  • The fix is probably to compute the toolbar's x+width and y+height, and make sure that those two coordinates are not outside the viewport's width and height. If it is, adjust the toolbar's x and y
  • The toolbar has a way of staying on the screen if it is not dragged before zooming. Perhaps that codepath could be used.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@Novem_Linguae I made a patch for fixing this issue , here is the relevant screencast .

Change #1013680 had a related patch set uploaded (by Aklapper; author: Rockingpenny4):

[mediawiki/extensions/PageTriage@master] Fixes toolbar falling off screen on zooming

https://gerrit.wikimedia.org/r/1013680

Change #1013680 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Fixes toolbar falling off screen on zooming

https://gerrit.wikimedia.org/r/1013680

Samwalton9-WMF subscribed.

Appears to be resolved in production :)