Page MenuHomePhabricator

Make #siteSub element visible by default
Open, MediumPublic3 Estimated Story Points

Description

NOTE: The current default is confusing to new wikis transitioning to the skin.

The #siteSub element, which contains text like "From Wikipedia, the free encyclopedia", is hidden by default and needs to be overridden by other styles, such as site styles:

At the time of this writing, Vector's resources/common/typography.less file sets the default:

// T335625 - Move siteSub into common.less to prevent it from being feature-flagged
// and overriding on-wiki modifications.
#siteSub {
	// By default the sitesub (i.e. tagline) is hidden as it was hidden in Vector legacy but site styles can reveal.
	display: none;
}

But the default (hidden) results in a UBN as T335625 has shown. Therefore, we should consider making the #siteSub element visible by default. Site styles/other styles can then hide it if necessary by overriding it.

Acceptance Criteria

  • The #siteSub element appears in legacy and vector-2022 without needing site styles to make it visible
  • Check which wikis do NOT override this style (using https://global-search.toolforge.org/ might help) and edit their site styles to hide the #siteSub element.

Event Timeline

LGoto set the point value for this task to 3.May 18 2023, 5:20 PM

I've kind of always wondered why this was hidden.

Check which wikis do NOT override this style (using https://global-search.toolforge.org/ might help) and edit their site styles to hide the #siteSub element.

It might be more prudent to let wikis know the default is going to flip and then let them make modifications, with an invitation to here(ish) if they don't want the element and don't know how to change it. I otherwise anticipate a lot of work.