Vector sticky header visual edit button no longer opens the editor at the current position without reloading the page. It reloads the page and jumps to the top instead. (See T296910 for details on how it should behave.)
Description
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Use jQuery fake events for sticky header edit buttons | mediawiki/skins/Vector | master | +6 -6 |
Related Objects
Event Timeline
No, that replaces disaptchEvent with a direct call to click. In the latter case you have no event object on which to inspect if default was prevented.
Change 926475 had a related patch set uploaded (by Esanders; author: Esanders):
[mediawiki/skins/Vector@master] Use jQuery fake events for stickeHeader edit buttons
Change 926475 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Use jQuery fake events for sticky header edit buttons
✅ Page doesn't reload
✅ viewport/content movement is minimized for VE
❓ When editing in source editor, it scrolls all the way to the top. Correct me if I am wrong but from the Transitioning from reading into editing part in T296910 , that seems to be expected.
Yes, that's expected, we didn't manage to implement a way to match the scroll position between the two editors. Thanks for testing it.