Page MenuHomePhabricator

Vector sticky header visual edit button no longer opens the editor at the current position without reloading the page
Closed, ResolvedPublic

Description

Vector sticky header visual edit button no longer opens the editor at the current position without reloading the page. It reloads the page and jumps to the top instead. (See T296910 for details on how it should behave.)

Event Timeline

Esanders triaged this task as High priority.Jun 1 2023, 5:21 PM
Esanders added a project: Regression.

That looks similar to T336931 then, and probably the same fix would work?

No, that replaces disaptchEvent with a direct call to click. In the latter case you have no event object on which to inspect if default was prevented.

Change 926475 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/skins/Vector@master] Use jQuery fake events for stickeHeader edit buttons

https://gerrit.wikimedia.org/r/926475

ppelberg moved this task from To Triage to Triaged on the VisualEditor board.
ppelberg subscribed.

Change 926475 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Use jQuery fake events for sticky header edit buttons

https://gerrit.wikimedia.org/r/926475

✅ Page doesn't reload
✅ viewport/content movement is minimized for VE
❓ When editing in source editor, it scrolls all the way to the top. Correct me if I am wrong but from the Transitioning from reading into editing part in T296910 , that seems to be expected.

See https://photos.app.goo.gl/owBnuxScR2Ve2xir5

❓ When editing in source editor, it scrolls all the way to the top. Correct me if I am wrong but from the Transitioning from reading into editing part in T296910 , that seems to be expected.

Yes, that's expected, we didn't manage to implement a way to match the scroll position between the two editors. Thanks for testing it.

❓ When editing in source editor, it scrolls all the way to the top. Correct me if I am wrong but from the Transitioning from reading into editing part in T296910 , that seems to be expected.

Yes, that's expected, we didn't manage to implement a way to match the scroll position between the two editors. Thanks for testing it.

Verifying this since it works as expected. Thanks.

ppelberg claimed this task.