Page MenuHomePhabricator
Create Task
Maniphest T336641

Vector sticky header watch/unwatch icon is always in the "not watched" state
Closed, ResolvedPublic0 Estimated Story Points
Actions

Description

Vector sticky header watch/unwatch icon is always in the "not watched" state, even when I am watching the page.

Testing on https://www.mediawiki.org/wiki/Wikimedia_Hackathon_2023/Program:

image.png (2×3 px, 1 MB)

Note how the icon is empty (indicating that the page is not watched), but the tooltip on the button says that clicking it will remove the page from my watchlist, because I am in fact watching it.

QA Results - Prod

ACStatusDetails
1✅T336641#8857529

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Ensure mw-watchlink is used for the sticky header watchlinkmediawiki/skins/Vectorwmf/1.41.0-wmf.8+6 -3
Consolidate watchstar icon updating logic under watchstar.jsmediawiki/skins/Vectorwmf/1.41.0-wmf.8+73 -63
Consolidate watchstar icon updating logic under watchstar.jsmediawiki/skins/Vectorwmf/1.41.0-wmf.9+73 -63
Ensure mw-watchlink is used for the sticky header watchlinkmediawiki/skins/Vectorwmf/1.41.0-wmf.9+6 -3
Consolidate watchstar icon updating logic under watchstar.jsmediawiki/skins/Vectormaster+73 -63
Ensure mw-watchlink is used for the sticky header watchlinkmediawiki/skins/Vectormaster+6 -3
Watchstar: update text updating logic to use lastElementChildmediawiki/coremaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.May 14 2023, 5:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 14 2023, 5:07 PM
Jdlrobson added a project: Web-Team-Backlog-Archived (Web Team FY2022-23 Q4 Sprint 3).May 15 2023, 2:19 PM
Jdlrobson triaged this task as High priority.May 15 2023, 2:29 PM
Jdlrobson moved this task from Incoming to Blocked on Others on the Web-Team-Backlog-Archived (Web Team FY2022-23 Q4 Sprint 3) board.May 15 2023, 5:16 PM
Jdlrobson set the point value for this task to 0.
gerritbot added a comment.May 15 2023, 7:07 PM

Change 919881 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Consolidate watchstar icon updating logic under watchstar.js

https://gerrit.wikimedia.org/r/919881

gerritbot added a project: Patch-For-Review.May 15 2023, 7:07 PM

Change 919880 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/core@master] Watchstar: update text updating logic to use lastElementChild

https://gerrit.wikimedia.org/r/919880

gerritbot added a comment.May 16 2023, 12:55 AM

Change 919880 merged by jenkins-bot:

[mediawiki/core@master] Watchstar: update text updating logic to use lastElementChild

https://gerrit.wikimedia.org/r/919880

Jdlrobson moved this task from Blocked on Others to Code Review on the Web-Team-Backlog-Archived (Web Team FY2022-23 Q4 Sprint 3) board.May 16 2023, 4:45 PM
gerritbot added a comment.May 16 2023, 4:46 PM

Change 920347 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Ensure mw-watchlink is used for the sticky header watchlink

https://gerrit.wikimedia.org/r/920347

gerritbot added a comment.May 16 2023, 6:54 PM

Change 920347 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Ensure mw-watchlink is used for the sticky header watchlink

https://gerrit.wikimedia.org/r/920347

gerritbot added a comment.May 16 2023, 6:55 PM

Change 919881 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Consolidate watchstar icon updating logic under watchstar.js

https://gerrit.wikimedia.org/r/919881

gerritbot added a comment.May 16 2023, 6:56 PM

Change 920239 had a related patch set uploaded (by Jdrewniak; author: Bernard Wang):

[mediawiki/skins/Vector@wmf/1.41.0-wmf.8] Ensure mw-watchlink is used for the sticky header watchlink

https://gerrit.wikimedia.org/r/920239

gerritbot added a comment.May 16 2023, 7:00 PM

Change 920240 had a related patch set uploaded (by Jdrewniak; author: Bernard Wang):

[mediawiki/skins/Vector@wmf/1.41.0-wmf.9] Ensure mw-watchlink is used for the sticky header watchlink

https://gerrit.wikimedia.org/r/920240

gerritbot added a comment.May 16 2023, 7:01 PM

Change 920241 had a related patch set uploaded (by Jdrewniak; author: Bernard Wang):

[mediawiki/skins/Vector@wmf/1.41.0-wmf.8] Consolidate watchstar icon updating logic under watchstar.js

https://gerrit.wikimedia.org/r/920241

gerritbot added a comment.May 16 2023, 7:02 PM

Change 920242 had a related patch set uploaded (by Jdrewniak; author: Bernard Wang):

[mediawiki/skins/Vector@wmf/1.41.0-wmf.9] Consolidate watchstar icon updating logic under watchstar.js

https://gerrit.wikimedia.org/r/920242

gerritbot added a comment.May 16 2023, 8:28 PM

Change 920240 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.41.0-wmf.9] Ensure mw-watchlink is used for the sticky header watchlink

https://gerrit.wikimedia.org/r/920240

Stashbot mentioned this in T336640: Vector sticky header watch/unwatch button disappears when clicked.May 16 2023, 8:29 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-16T20:29:09Z] <jdrewniak@deploy1002> Started scap: Backport for [[gerrit:920240|Ensure mw-watchlink is used for the sticky header watchlink (T336640 T336641)]]

Stashbot added a comment.May 16 2023, 8:30 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-16T20:30:41Z] <jdrewniak@deploy1002> jdrewniak: Backport for [[gerrit:920240|Ensure mw-watchlink is used for the sticky header watchlink (T336640 T336641)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet

Stashbot added a comment.May 16 2023, 8:36 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-16T20:36:53Z] <jdrewniak@deploy1002> Finished scap: Backport for [[gerrit:920240|Ensure mw-watchlink is used for the sticky header watchlink (T336640 T336641)]] (duration: 07m 44s)

gerritbot added a comment.May 16 2023, 8:39 PM

Change 920242 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.41.0-wmf.9] Consolidate watchstar icon updating logic under watchstar.js

https://gerrit.wikimedia.org/r/920242

Stashbot added a comment.May 16 2023, 8:39 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-16T20:39:47Z] <jdrewniak@deploy1002> Started scap: Backport for [[gerrit:920242|Consolidate watchstar icon updating logic under watchstar.js (T336640 T336641)]]

Stashbot added a comment.May 16 2023, 8:41 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-16T20:41:25Z] <jdrewniak@deploy1002> jdrewniak: Backport for [[gerrit:920242|Consolidate watchstar icon updating logic under watchstar.js (T336640 T336641)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet

Stashbot added a comment.May 16 2023, 8:49 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-16T20:49:06Z] <jdrewniak@deploy1002> Finished scap: Backport for [[gerrit:920242|Consolidate watchstar icon updating logic under watchstar.js (T336640 T336641)]] (duration: 09m 19s)

Jdlrobson assigned this task to Edtadros.May 16 2023, 9:37 PM
Jdlrobson moved this task from Code Review to QA in Production on the Web-Team-Backlog-Archived (Web Team FY2022-23 Q4 Sprint 3) board.
Jdlrobson subscribed.

Let's verify this in production (mediawki.org)

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 16 2023, 10:01 PM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.9; 2023-05-15); removed MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 16 2023, 11:01 PM
Edtadros closed this task as Resolved.May 16 2023, 11:06 PM
Edtadros removed Edtadros as the assignee of this task.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: mediawiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Vector sticky header watch/unwatch icon is always in the "not watched" state, even when I am watching the page.
This was validated here: T336640#8857506

Edtadros updated the task description. (Show Details)May 16 2023, 11:07 PM
gerritbot added a comment.May 17 2023, 2:13 PM

Change 920241 abandoned by Jdrewniak:

[mediawiki/skins/Vector@wmf/1.41.0-wmf.8] Consolidate watchstar icon updating logic under watchstar.js

Reason:

Deployed only to 1.41.0-wmf.8

https://gerrit.wikimedia.org/r/920241

gerritbot added a comment.May 17 2023, 2:14 PM

Change 920239 abandoned by Jdrewniak:

[mediawiki/skins/Vector@wmf/1.41.0-wmf.8] Ensure mw-watchlink is used for the sticky header watchlink

Reason:

Deeployed only to 1.41.0-wmf.8

https://gerrit.wikimedia.org/r/920239

Maintenance_bot removed a project: Patch-For-Review.May 17 2023, 2:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits