Page MenuHomePhabricator

Vector sticky header watch/unwatch icon is always in the "not watched" state
Closed, ResolvedPublic0 Estimated Story Points

Description

Vector sticky header watch/unwatch icon is always in the "not watched" state, even when I am watching the page.

Testing on https://www.mediawiki.org/wiki/Wikimedia_Hackathon_2023/Program:

image.png (2×3 px, 1 MB)

Note how the icon is empty (indicating that the page is not watched), but the tooltip on the button says that clicking it will remove the page from my watchlist, because I am in fact watching it.

QA Results - Prod

ACStatusDetails
1T336641#8857529

Event Timeline

Change 919881 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Consolidate watchstar icon updating logic under watchstar.js

https://gerrit.wikimedia.org/r/919881

Change 919880 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/core@master] Watchstar: update text updating logic to use lastElementChild

https://gerrit.wikimedia.org/r/919880

Change 919880 merged by jenkins-bot:

[mediawiki/core@master] Watchstar: update text updating logic to use lastElementChild

https://gerrit.wikimedia.org/r/919880

Change 920347 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Ensure mw-watchlink is used for the sticky header watchlink

https://gerrit.wikimedia.org/r/920347

Change 920347 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Ensure mw-watchlink is used for the sticky header watchlink

https://gerrit.wikimedia.org/r/920347

Change 919881 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Consolidate watchstar icon updating logic under watchstar.js

https://gerrit.wikimedia.org/r/919881

Change 920239 had a related patch set uploaded (by Jdrewniak; author: Bernard Wang):

[mediawiki/skins/Vector@wmf/1.41.0-wmf.8] Ensure mw-watchlink is used for the sticky header watchlink

https://gerrit.wikimedia.org/r/920239

Change 920240 had a related patch set uploaded (by Jdrewniak; author: Bernard Wang):

[mediawiki/skins/Vector@wmf/1.41.0-wmf.9] Ensure mw-watchlink is used for the sticky header watchlink

https://gerrit.wikimedia.org/r/920240

Change 920241 had a related patch set uploaded (by Jdrewniak; author: Bernard Wang):

[mediawiki/skins/Vector@wmf/1.41.0-wmf.8] Consolidate watchstar icon updating logic under watchstar.js

https://gerrit.wikimedia.org/r/920241

Change 920242 had a related patch set uploaded (by Jdrewniak; author: Bernard Wang):

[mediawiki/skins/Vector@wmf/1.41.0-wmf.9] Consolidate watchstar icon updating logic under watchstar.js

https://gerrit.wikimedia.org/r/920242

Change 920240 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.41.0-wmf.9] Ensure mw-watchlink is used for the sticky header watchlink

https://gerrit.wikimedia.org/r/920240

Mentioned in SAL (#wikimedia-operations) [2023-05-16T20:29:09Z] <jdrewniak@deploy1002> Started scap: Backport for [[gerrit:920240|Ensure mw-watchlink is used for the sticky header watchlink (T336640 T336641)]]

Mentioned in SAL (#wikimedia-operations) [2023-05-16T20:30:41Z] <jdrewniak@deploy1002> jdrewniak: Backport for [[gerrit:920240|Ensure mw-watchlink is used for the sticky header watchlink (T336640 T336641)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-05-16T20:36:53Z] <jdrewniak@deploy1002> Finished scap: Backport for [[gerrit:920240|Ensure mw-watchlink is used for the sticky header watchlink (T336640 T336641)]] (duration: 07m 44s)

Change 920242 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.41.0-wmf.9] Consolidate watchstar icon updating logic under watchstar.js

https://gerrit.wikimedia.org/r/920242

Mentioned in SAL (#wikimedia-operations) [2023-05-16T20:39:47Z] <jdrewniak@deploy1002> Started scap: Backport for [[gerrit:920242|Consolidate watchstar icon updating logic under watchstar.js (T336640 T336641)]]

Mentioned in SAL (#wikimedia-operations) [2023-05-16T20:41:25Z] <jdrewniak@deploy1002> jdrewniak: Backport for [[gerrit:920242|Consolidate watchstar icon updating logic under watchstar.js (T336640 T336641)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-05-16T20:49:06Z] <jdrewniak@deploy1002> Finished scap: Backport for [[gerrit:920242|Consolidate watchstar icon updating logic under watchstar.js (T336640 T336641)]] (duration: 09m 19s)

Jdlrobson subscribed.

Let's verify this in production (mediawki.org)

Edtadros removed Edtadros as the assignee of this task.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: mediawiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Vector sticky header watch/unwatch icon is always in the "not watched" state, even when I am watching the page.
This was validated here: T336640#8857506

Change 920241 abandoned by Jdrewniak:

[mediawiki/skins/Vector@wmf/1.41.0-wmf.8] Consolidate watchstar icon updating logic under watchstar.js

Reason:

Deployed only to 1.41.0-wmf.8

https://gerrit.wikimedia.org/r/920241

Change 920239 abandoned by Jdrewniak:

[mediawiki/skins/Vector@wmf/1.41.0-wmf.8] Ensure mw-watchlink is used for the sticky header watchlink

Reason:

Deeployed only to 1.41.0-wmf.8

https://gerrit.wikimedia.org/r/920239