Page MenuHomePhabricator
Create Task
Maniphest T336686

Train blocker task has wrong navigation to previous train
Open, LowPublicBUG REPORT
Actions

Description

https://train-blockers.toolforge.org/ currently points to wmf.8 task T330215

The Previous 1.41.0-wmf.8 button should point to T330214: 1.41.0-wmf.8 deployment blockers but it instead points to T326177

That task got a Release Version instead of the tag MW-1.41-notes (1.41.0-wmf.8; 2023-05-08)

Aklapper set Release Version to 1.41.0-wmf.8.

I think that is the reason since the form configuration https://phabricator.wikimedia.org/transactions/editengine/maniphest.task/view/34/ has:

The release details are automatically generated from a template which uses the contents of the Release Date and Release Version fields to dynamically build all of the details for a given deployment cycle.

So I guess when the field got set on T326177 it ended up being considered part of the series of blocker. There might be some guard to add to the code.

Related Objects

Event Timeline

hashar created this task.May 15 2023, 4:23 PM
Aklapper added a comment.May 20 2023, 10:19 AM

Editing T326177 meant using Form 46: I set the "MediaWiki Version" field; there is no "Release Version" field in that form. See T326177#8848980.

The "Release Version" field (Form 34) is the field used for "deployment blockers" tasks. Thus I'm puzzled by the line Aklapper set Release Version to 1.41.0-wmf.8.

There might be some guard to add to the code.

Could you elaborate which codebase this refers to?

Aklapper triaged this task as Low priority.Jul 12 2023, 9:08 PM
Aklapper added a project: Wikimedia-Phabricator-Extensions.
Aklapper changed the subtype of this task from "Task" to "Bug Report".
Aklapper moved this task from To Triage to Misc on the Phabricator board.

phabricator/extensions/src/customfields/ReleaseDetailsCustomField.php in GitLab:

// dirty manual query of the custom field storage table to get the value
// for the release.version field for the previous and next version
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL