Page MenuHomePhabricator
Create Task
Maniphest T336773

NotFoundError: Node.removeChild: The node to be removed is not a child of this node
Closed, ResolvedPublicBUG REPORT
Actions

Description

This error has been happening at a concerning rate, mostly on commonswiki since 10th May.
12,980 errors in wmf8, only 171 in the deploy before.
https://logstash.wikimedia.org/goto/6add4368db2f472c55cbb79e6ff60141

Stack trace suggests an issue on page load or inside a callback of a JSONP request:
at HTMLScriptElement.onComplete https://commons.wikimedia.org/w/load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector:9:242

The error is occurring for anonymous users

The error seems limited to file pages.

Screenshot 2023-05-16 at 8.08.05 AM.png (2,110×802 px, 180 KB)

I am unable to replicate it on page load but I do see an error Error: View mediainfoview does not exist in the JS console which suggest some kind of race condition.
What features are enabled on these pages that might have bugs in them?

Event Timeline

Jdlrobson created this task.May 16 2023, 3:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 16 2023, 3:13 PM
Jdlrobson added a comment.May 16 2023, 3:13 PM

I've added StructuredData as the most likely team to know about this page and where the bug could be happening.

Jdlrobson added a comment.May 16 2023, 3:20 PM

The bug also occurs as "NotFoundError: Node.removeChild: The node to be removed is not a child of this node" and some of the error stack traces contain calls to DDGRuntimeChecks.dispatch which I can't find in any code search.

Func subscribed.May 19 2023, 2:14 PM
In T336773#8855834, @Jdlrobson wrote:

The bug also occurs as "NotFoundError: Node.removeChild: The node to be removed is not a child of this node" and some of the error stack traces contain calls to DDGRuntimeChecks.dispatch which I can't find in any code search.

Searched DDGRuntimeChecks on github: duckduckgo/content-scope-scripts/src/features/runtime-checks.js#L68

Maybe related: https://github.com/duckduckgo/content-scope-scripts/pull/485/files

CBogen moved this task from Triage to SDoC Statements on the Structured-Data-Backlog board.May 22 2023, 4:40 PM
Maintenance_bot added a project: Commons.May 22 2023, 5:30 PM
Jdlrobson added a project: Local-Wiki-Template-And-Gadget-Issues.May 25 2023, 4:56 AM

Nice detective work @Func!

Umherirrender added a project: JavaScript.May 25 2023, 7:02 PM
Jdlrobson added a comment.May 25 2023, 8:46 PM

Raised upstream issue: https://github.com/duckduckgo/content-scope-scripts/issues/540

thcipriani moved this task from Untriaged to May 2023 on the Wikimedia-production-error board.Aug 31 2023, 3:53 PM
TheDJ closed this task as Resolved.Dec 23 2023, 6:58 PM
TheDJ assigned this task to Jdlrobson.
TheDJ subscribed.

While other variants of this error message still occur (53 times in 4 weeks), they are not the one that was triggered by duckduckgo, so I think this should be closed.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits