Page MenuHomePhabricator

[Zebra] ToC in sidebar overlaps footer area
Closed, DuplicatePublicBUG REPORT

Description

Steps to replicate the issue

What happens?:

Screenshot 2023-05-16 at 11.20.59 AM.png (782×383 px, 62 KB)

The ToC visually overlaps the footer

What should have happened instead?:
The ToC should not overlap the footer

Screenshot 2023-05-16 at 11.21.46 AM.png (636×571 px, 84 KB)

Technical notes:

This bug is due to changes in where position:sticky has been applied in Zebra. The position:sticky was moved one element up the dom tree,
from
.mw-page-container-inner > .vector-sticky-pinned-container > #vector-toc-pinned-container
to
.mw-page-container-inner > .vector-sticky-pinned-container

Event Timeline

This issue can be solved by implementing the solution proposed in T323141 - Combine mainMenu and toc grid areas into columnStart grid areas. That would provide this sidebar area with a more semantic wrapper element and provide the "sticky container" for the TOC. We can probably remove the .vector-sticky-pinned-container element when we do this too.