Page MenuHomePhabricator

Avoid the Contributions menu to disappear on mobile web
Closed, ResolvedPublic

Description

The "Contributions" option seems to have disappeared from the beta Wikipedia. The "Contributions" menu is a useful option for users to check their contributions, and to start new contributions (T322740) as this feature becomes available.

Below a comparison of English Wikipedia and Beta on mobile web. Notice the "Contributions" option missing in Beta.

English Wikipedia (link)Beta (link)
en.m.wikipedia.org_wiki_Moon(iPhone SE).png (1×750 px, 121 KB)
en.m.wikipedia.beta.wmflabs.org_wiki_Main_Page(iPhone SE) (1).png (1×750 px, 91 KB)

Event Timeline

After enabling the new entry point on mobile for a small set of wikis (T319362), the issue seems to have reached production. For example, on Bengali Wikipedia the "Contributions" option is no longer visible in the navigation menu:

bn.m.wikipedia.org_wiki_%E0%A6%AA%E0%A7%8D%E0%A6%B0%E0%A6%A7%E0%A6%BE%E0%A6%A8_%E0%A6%AA%E0%A6%BE%E0%A6%A4%E0%A6%BE(iPhone SE).png (1×750 px, 95 KB)

@Jdlrobson any idea on why this may be?

Steps to reproduce:

Make sure you have latest mediawiki, mobilefrontend and skins. Observe the "Contributions" menu in Mobile interface side menu. Then in LocalSettings.php add:

$wgSpecialContributeSkinsEnabled = [ 'vector', 'vector-2022', 'monobook', 'timeless', 'modern', 'cologneblue', 'minerva' ];

Refresh page, you will see Contributions menu disappeared.

Expected result is Contributions menu item replaced by "Contribute" menu item

Sidenote: I haven't enabled ['modern', 'cologneblue'] skins for Special:Contribute as they are not in the production Wikipedias. Should we still do that?

Yes, I can replicate this. It occurs in the non-AMC logged in mode.

I believe the issue is the key for the new menu item is not in this array:
https://github.com/wikimedia/mediawiki-skins-MinervaNeue/blob/master/includes/Menu/Main/DefaultMainMenuBuilder.php#L133

I am taking a break in my day due to timezones so will look into this later but language team should feel free to try that fix in the mean time.

Change 923248 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/skins/MinervaNeue@master] Show Contribute menu item in main menu when Special:Contribute is enabled

https://gerrit.wikimedia.org/r/923248

Change 923248 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Show Contribute menu item in main menu when Special:Contribute is enabled

https://gerrit.wikimedia.org/r/923248

Change 923268 had a related patch set uploaded (by KartikMistry; author: Santhosh):

[mediawiki/skins/MinervaNeue@wmf/1.41.0-wmf.9] Show Contribute menu item in main menu when Special:Contribute is enabled

https://gerrit.wikimedia.org/r/923268

Change 923269 had a related patch set uploaded (by KartikMistry; author: Santhosh):

[mediawiki/skins/MinervaNeue@wmf/1.41.0-wmf.10] Show Contribute menu item in main menu when Special:Contribute is enabled

https://gerrit.wikimedia.org/r/923269

Change 923268 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@wmf/1.41.0-wmf.9] Show Contribute menu item in main menu when Special:Contribute is enabled

https://gerrit.wikimedia.org/r/923268

Change 923269 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@wmf/1.41.0-wmf.10] Show Contribute menu item in main menu when Special:Contribute is enabled

https://gerrit.wikimedia.org/r/923269

Mentioned in SAL (#wikimedia-operations) [2023-05-25T13:52:07Z] <kartik@deploy1002> Started scap: Backport for [[gerrit:923268|Show Contribute menu item in main menu when Special:Contribute is enabled (T336838)]], [[gerrit:923269|Show Contribute menu item in main menu when Special:Contribute is enabled (T336838)]]

Mentioned in SAL (#wikimedia-operations) [2023-05-25T13:53:37Z] <kartik@deploy1002> kartik: Backport for [[gerrit:923268|Show Contribute menu item in main menu when Special:Contribute is enabled (T336838)]], [[gerrit:923269|Show Contribute menu item in main menu when Special:Contribute is enabled (T336838)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-05-25T14:08:03Z] <kartik@deploy1002> Finished scap: Backport for [[gerrit:923268|Show Contribute menu item in main menu when Special:Contribute is enabled (T336838)]], [[gerrit:923269|Show Contribute menu item in main menu when Special:Contribute is enabled (T336838)]] (duration: 15m 56s)

Mentioned in SAL (#wikimedia-operations) [2023-05-25T14:10:04Z] <kartik@deploy1002> Started scap: Backport for [[gerrit:923268|Show Contribute menu item in main menu when Special:Contribute is enabled (T336838)]], [[gerrit:923269|Show Contribute menu item in main menu when Special:Contribute is enabled (T336838)]]

Mentioned in SAL (#wikimedia-operations) [2023-05-25T14:11:42Z] <kartik@deploy1002> kartik: Backport for [[gerrit:923268|Show Contribute menu item in main menu when Special:Contribute is enabled (T336838)]], [[gerrit:923269|Show Contribute menu item in main menu when Special:Contribute is enabled (T336838)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-05-25T15:18:12Z] <kartik@deploy1002> Finished scap: Backport for [[gerrit:923268|Show Contribute menu item in main menu when Special:Contribute is enabled (T336838)]], [[gerrit:923269|Show Contribute menu item in main menu when Special:Contribute is enabled (T336838)]] (duration: 68m 07s)

Mentioned in SAL (#wikimedia-operations) [2023-05-25T15:20:29Z] <kartik@deploy1002> Started scap: Backport for [[gerrit:923269|Show Contribute menu item in main menu when Special:Contribute is enabled (T336838)]]

Mentioned in SAL (#wikimedia-operations) [2023-05-25T15:21:58Z] <kartik@deploy1002> kartik: Backport for [[gerrit:923269|Show Contribute menu item in main menu when Special:Contribute is enabled (T336838)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-05-25T15:27:30Z] <kartik@deploy1002> Finished scap: Backport for [[gerrit:923269|Show Contribute menu item in main menu when Special:Contribute is enabled (T336838)]] (duration: 07m 01s)

We've backport fix to wmf.9 and wmf.10. Contribute menu should be visible back to Wikipedias where we deployed Special:Contribute entry point.

Change 923383 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Move to exclude list rather than include list

https://gerrit.wikimedia.org/r/923383

Looks like there are still a couple of issues here:

  1. The contribute menu is now showing to anonymous users which is unexpected:

Screenshot 2023-05-25 at 7.10.29 PM.png (890×1 px, 143 KB)

  1. The link is not being instrumented in MobileWebUIClickTracking.

Both fixes in the above patch.

(This will likely create interrupt work for web team in future so I'd like to fix this now while we're familiar with the problem)

Change 923383 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Move to exclude list rather than include list

https://gerrit.wikimedia.org/r/923383

Change 928965 had a related patch set uploaded (by Jdrewniak; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Fixes: Sandbox link should not show in main menu

https://gerrit.wikimedia.org/r/928965

Change 928965 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Fixes: Sandbox link should not show in main menu

https://gerrit.wikimedia.org/r/928965

Jdlrobson claimed this task.

Menu is appearing in both AMC and standard mode:

Screenshot 2023-06-12 at 5.05.13 PM.png (351×1 px, 83 KB)

Screenshot 2023-06-12 at 5.05.30 PM.png (354×709 px, 44 KB)