Page MenuHomePhabricator

Android app should show search suggestions
Closed, ResolvedPublic

Description

Just like the desktop site. Text input on mobiles suck so lets make it easier by making our users type less.


Version: 1.0.0 (Android)
Severity: enhancement

Details

Reference
bz31686

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 21 2014, 11:57 PM
bzimport set Reference to bz31686.

anis wrote:

latest master

brion added a comment.Oct 21 2011, 6:31 PM

What about latest master?

anis wrote:

Sorry mistake :/

brion added a comment.Oct 31 2011, 2:26 AM

Ok, current state is:

  • there are no suggestions while you type
  • when you submit your search, instead of an actual search we look up the search suggestions based on what you typed.

So basically we need to take the suggestion search that it does now and move that to *while you type*, and then change the final search to do a fulltext search instead of getting typeahead suggestions.

brion added a comment.Nov 2 2011, 9:59 PM

Seems pretty buggy:

  • sometimes comes back with seemingly wrong or early results: eg typing "thing" and ending up with suggestions that fit with just the initial "t"
  • sometimes all the results disappear from screen
  • sometimes navigates to a page before you've completed the search; for instance type "supreme" or "new york" and you may find yourself at those pages.
brion added a comment.Nov 2 2011, 10:02 PM

Tapping on a suggestion also often closes the list without showing any focus behavior in the list, then focuses & shows a highlight ring on some UI element that was on the page behind, such as a link, until the target page loads.

herman.wong wrote:

https://github.com/nitobi/Wikipedia/commit/3d429186f9881a6db767040adefb274eccc60d85

this should fix the following symptoms:

  • sometimes all the results disappear from screen
  • sometimes navigates to a page before you've completed the search; for

instance type "supreme" or "new york" and you may find yourself at those pages.

brion added a comment.Nov 2 2011, 11:23 PM

Awesome, it's working a lot smoother now. A little tweaking on the click behavior should pretty much do it for now!

herman.wong wrote:

https://github.com/nitobi/Wikipedia/commit/205829daf164d3e8191b9f33cb5a71a57f059cf3

this should prevent the focus on UI element on the page behind.

herman.wong wrote:

https://github.com/nitobi/Wikipedia/commit/8c19042190985ddd504173458620c6166999abf7

the search results & search suggestions now have an active state when the item is clicked on.