Page MenuHomePhabricator

Error: Typed property GrowthExperiments\NewcomerTasks\AddImage\ImageRecommendationImage::$sectionNumber must not be accessed before initialization
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error
labels.normalized_message
[{reqId}] {exception_url}   Error: Typed property GrowthExperiments\NewcomerTasks\AddImage\ImageRecommendationImage::$sectionNumber must not be accessed before initialization
error.stack_trace
from /srv/mediawiki/php-1.41.0-wmf.9/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationImage.php(141)
#0 /srv/mediawiki/php-1.41.0-wmf.9/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendation.php(84): GrowthExperiments\NewcomerTasks\AddImage\ImageRecommendationImage->toArray()
#1 [internal function]: GrowthExperiments\NewcomerTasks\AddImage\ImageRecommendation::GrowthExperiments\NewcomerTasks\AddImage\{closure}(GrowthExperiments\NewcomerTasks\AddImage\ImageRecommendationImage)
#2 /srv/mediawiki/php-1.41.0-wmf.9/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendation.php(85): array_map(Closure, array)
#3 /srv/mediawiki/php-1.41.0-wmf.9/extensions/GrowthExperiments/includes/HomepageHooks.php(450): GrowthExperiments\NewcomerTasks\AddImage\ImageRecommendation->toArray()
#4 /srv/mediawiki/php-1.41.0-wmf.9/includes/HookContainer/HookContainer.php(160): GrowthExperiments\HomepageHooks->onBeforePageDisplay(OutputPage, MediaWiki\Skins\Vector\SkinVector22)
#5 /srv/mediawiki/php-1.41.0-wmf.9/includes/HookContainer/HookRunner.php(941): MediaWiki\HookContainer\HookContainer->run(string, array, array)
#6 /srv/mediawiki/php-1.41.0-wmf.9/includes/OutputPage.php(2921): MediaWiki\HookContainer\HookRunner->onBeforePageDisplay(OutputPage, MediaWiki\Skins\Vector\SkinVector22)
#7 /srv/mediawiki/php-1.41.0-wmf.9/includes/MediaWiki.php(943): OutputPage->output(boolean)
#8 /srv/mediawiki/php-1.41.0-wmf.9/includes/MediaWiki.php(579): MediaWiki->main()
#9 /srv/mediawiki/php-1.41.0-wmf.9/index.php(50): MediaWiki->run()
#10 /srv/mediawiki/php-1.41.0-wmf.9/index.php(46): wfIndexMain()
#11 /srv/mediawiki/w/index.php(3): require(string)
#12 {main}
Impact
Notes

A few of these seen immediately after T330215: 1.41.0-wmf.9 deployment blockers to group2.

For my reference, the now-fixed GrowthExperiments\NewcomerTasks one was T336962: UnexpectedValueException: Unknown image suggestions API kind: istype-depicts.

Details

Request URL
https://pt.wikipedia.org/w/index.php?geclickid=*&genewcomertasktoken=*&gesuggestededit=*&getasktype=*&section=*&title=*&veaction=*

Event Timeline

It's always initialized in the constructor. With only 4 errors, this was probably some transient issue while the code was half-deployed.

brennen claimed this task.

Yeah. Haven't seen since 21:31 UTC, so that checks out.