DefaultView: Create a custom Argument Reference component with a selector instead of a text input field
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	DVrandecic
	May 18 2023, 11:23 PM

Description

When selecting an Argument Reference, because we are using the fallback generic component of ZObjectKeyValueSet, we need to input the Z18K1/Key id manually.
It would be more user friendly to simply offer the argument reference available options in a dropdown

Current behavior

Go to https://wikifunctions.beta.wmflabs.org/wiki/Z10748?action=edit&view=default-view
Expand Composition
Expand First String
On Type drop down, change from String to Z18 / Argument reference
We get a field to enter the Key Id manually

Desired behavior/Acceptance criteria

Argument reference should be an ad-hoc component with a dropdown that allows us to select the available arguments in the function being implemented.

(There might be use cases for entering a Key id manually, but the main uses cases will be to select one of the existing arguments)

Devices and Design (URLs or screenshots)

Desktop: ...
Small screens/mobile: ...

Completion checklist

Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Front-end_Task/Bug_Completion_Checklist

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Create an Argument Reference component	mediawiki/extensions/WikiLambda	master	+394 -31

Customize query in gerrit

Related Objects

Mentioned In: T343605: We need the arguments' ZIDs during composition
T339235: Creating a function by composition using argument reference does not load all of the current function’s arguments (only loads one)

Event Timeline

DVrandecic created this task.May 18 2023, 11:23 PM

DVrandecic moved this task from To Triage to Phase θ – Throttling on the Abstract Wikipedia team board.May 22 2023, 4:15 PM

DVrandecic edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.

Jdforrester-WMF moved this task from Phase θ – Throttling to To triage: Nice-to-haves on the Abstract Wikipedia team board.Jun 16 2023, 9:33 AM

Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase θ – Throttling).

gengh renamed this task from Select argument references instead of type key IDs to DefaultView: Create a custom Argument Reference component with a selector instead of a text input field.Jun 20 2023, 9:05 AM

gengh updated the task description. (Show Details)

gengh mentioned this in T339235: Creating a function by composition using argument reference does not load all of the current function’s arguments (only loads one).

DVrandecic mentioned this in T343605: We need the arguments' ZIDs during composition.Aug 5 2023, 12:42 AM

DVrandecic triaged this task as High priority.Aug 5 2023, 12:46 AM

DVrandecic lowered the priority of this task from High to Medium.

DVrandecic updated the task description. (Show Details)

DVrandecic moved this task from To triage: Nice-to-haves to Needs Product/Design on the Abstract Wikipedia team board.

gengh claimed this task.Sep 26 2023, 9:56 AM

Change 961728 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] [WIP] Create an Argument Reference component

https://gerrit.wikimedia.org/r/961728

gerritbot added a project: Patch-For-Review.Sep 28 2023, 9:29 AM

Jdforrester-WMF changed the task status from Open to In Progress.Sep 28 2023, 6:06 PM

Jdforrester-WMF moved this task from Needs Product/Design to In Progress on the Abstract Wikipedia team board.

Change 961728 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Create an Argument Reference component

https://gerrit.wikimedia.org/r/961728

Maintenance_bot removed a project: Patch-For-Review.Sep 28 2023, 6:10 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.29; 2023-10-03).Sep 29 2023, 10:01 AM

Jdforrester-WMF moved this task from In Progress to To deploy on the Abstract Wikipedia team board.Sep 29 2023, 1:04 PM

Jdforrester-WMF moved this task from To deploy to Verify in production on the Abstract Wikipedia team board.Oct 10 2023, 2:19 PM

wikifunctions betalabs (the example in the task description - https://wikifunctions.beta.wmflabs.org/wiki/Z10748?action=edit&view=default-view)

Screen Shot 2023-10-11 at 3.24.52 PM.png (1×1 px, 81 KB)

Checked on wikifunctions wmf.30 - https://www.wikifunctions.org/view/en/Z11135

Screen Shot 2023-10-11 at 3.30.08 PM.png (1×2 px, 211 KB)

Mobile

Screen Shot 2023-10-11 at 3.44.52 PM.png (1×796 px, 107 KB)

Etonkovidova updated the task description. (Show Details)Oct 11 2023, 10:46 PM

	F38213411: Screen Shot 2023-10-11 at 3.44.52 PM.png
	Oct 11 2023, 10:45 PM

	F38213355: Screen Shot 2023-10-11 at 3.30.08 PM.png
	Oct 11 2023, 10:45 PM

	F38213352: Screen Shot 2023-10-11 at 3.24.52 PM.png
	Oct 11 2023, 10:45 PM

DefaultView: Create a custom Argument Reference component with a selector instead of a text input fieldClosed, ResolvedPublicActions

Description

Description

Completion checklist

Details

Related Objects

Event Timeline

DefaultView: Create a custom Argument Reference component with a selector instead of a text input field
Closed, ResolvedPublic
Actions