Page MenuHomePhabricator

ENotif mails are not automatically reenabled after sent when watching users visits watched and notified page
Closed, ResolvedPublic

Description

ENotif mails are not automatically reenabled after sent when watching users
visits watched and notified page.

The reason is a (currently) misplaced statement $wgUser->clearNotification(
$this->mTitle) in function view() in Article.php . In older versions it works
perfect: the purpose of this statement is to reset the email notification
timestamp for the currently visiting user and the current page (watched) in
table watchlist. This re-enables the next ENotif, when another user changes that
pages later - otherwise it BLOCKS the sending.

The problem at them moment is, that it BLOCKS further sendings, because the
clearNotification is not called when the watching user only visits the page.

I need to move that code further up, but exact tests are needed --> ( to-do-list
Tom )
Tom

  • for ENotif

PATCH WILL FOLLOW IN ABOUT ONE DAY


Version: 1.5.x
Severity: normal
URL: http://meta.wikipedia.org/Enotif

Details

Reference
bz1370

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 21 2014, 8:11 PM
bzimport set Reference to bz1370.
Wikinaut created this task.Jan 20 2005, 3:01 AM

Created attachment 222
Patch to reenable ENotifs when watching user visits watched page with changes

JeLuf or Hashar: please can you commit this to CVS HEAD, otherwise ENotifs are
not reenabled automagically; I still have no CVS HEAD access rights.

Wikinaut Tom

attachment patch_for_1370.diff ignored as obsolete

Created attachment 223
correction patch (delete a wrong comma)

attachment patch_for_1370.diff ignored as obsolete

please, can some apply the patch for me now, I have no CVS access rights.

jeluf wrote:

patching file includes/Article.php
Hunk #1 succeeded at 692 (offset 4 lines).
Hunk #2 succeeded at 1786 (offset -12 lines).
patching file includes/User.php
patch: **** malformed patch at line 49:

Looking at User.php, the context does not match, and I don't have an idea how it
should look like.

Please re-add the "patch" keyword after uploading a new patch.

Created attachment 273
replacement for older patch

attachment cvs.diff ignored as obsolete

Created attachment 368
reminder (to patch in CVS HEAD, please)

patch

Attached:

brion added a comment.Mar 15 2005, 7:28 AM

Committed.