Page MenuHomePhabricator
Create Task
Maniphest T337017

Remove "Action Has No Effect" warning dialog when removing auto assigned user
Closed, ResolvedPublic
Actions

Description

Upstream: https://we.phorge.it/T15164

Currently unassigned tasks will get the user executing the action assigned when the task is marked as resolved. If you do not want that so happen and remove yourself in the step, you'll get a warning message, that you one of your actions has no effect.

It would be really nice to at list have this message removed or suppressed in that use case. It's annoying and not quite correct in that case.

P.S.: Maybe this task will be invalid when [V22] will lead to removing the auto assignment in the first place.

Related Objects
Search...

Event Timeline

WMDE-Fisch created this task.May 19 2023, 9:42 AM
Aklapper renamed this task from Avoid the "Action with no effect" warning when removing the auto assigned user to Remove "Action Has No Effect" warning dialog when removing auto assigned user.May 19 2023, 10:03 AM
Aklapper triaged this task as Medium priority.EditedMay 19 2023, 10:06 AM

Makes sense to me. That's src/applications/transactions/response/PhabricatorApplicationTransactionNoEffectResponse.php and src/applications/transactions/response/PhabricatorApplicationTransactionNoEffectResponse.php in https://gitlab.wikimedia.org/repos/phabricator/phabricator

Aklapper added a comment.May 23 2023, 3:59 PM

Should probably check the editengine.actions JSON for {"type":"status","value":"resolved","initialValue":null} && {"type":"owner","value":[],"initialValue":[]} and not trigger when owner value and initialValue are still the same.

Aklapper edited projects, added Phabricator (Upstream), Upstream; removed Phabricator.May 28 2023, 3:11 PM
Aklapper updated the task description. (Show Details)
Aklapper moved this task from Backlog to Upstreamed on the Phabricator (Upstream) board.
Aklapper moved this task from Backlog to Reported Upstream on the Upstream board.
Aklapper claimed this task.Nov 29 2023, 3:02 PM
Aklapper moved this task from Reported Upstream to Patch proposed upstream on the Upstream board.
Aklapper changed the task status from Open to Stalled.Mar 17 2024, 4:49 PM
Aklapper moved this task from Upstreamed to Solved upstream on the Phabricator (Upstream) board.
Aklapper moved this task from Patch proposed upstream to Patch merged upstream on the Upstream board.

Fixed in upstream; setting status to Stalled as this is now waiting for a new upstream release and us to pull and deploy it

Aklapper added a subtask: T368453: Update to Phorge upstream 2024.19 release.Jun 25 2024, 7:51 PM
Aklapper removed a parent task: T261483: Disable auto-assign/claim feature.
Aklapper closed this task as Resolved.Jul 16 2024, 3:25 PM

This should have gotten resolved by today's deployment pulling and deploying the 2024.19 upstream version. If not, please comment.

Aklapper closed subtask T368453: Update to Phorge upstream 2024.19 release as Resolved.Jul 16 2024, 3:27 PM
Krinkle awarded a token.Jul 17 2024, 11:43 PM
WMDE-Fisch awarded a token.Jul 18 2024, 6:41 AM
Pcoombe awarded a token.Jul 18 2024, 10:18 AM
Michael awarded a token.Jul 19 2024, 2:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits