Page MenuHomePhabricator

Android app shows blank screen after network failure
Closed, ResolvedPublic

Description

If we fail to retrieve data from a network the view just shows a blank page. You can access buttons but can't reload the page in any way.


Version: 1.0.0 (Android)
Severity: critical

Details

Reference
bz31702

Related Objects

StatusAssignedTask
ResolvedNone
Resolved Tfinc
Resolved yuvipanda
Resolved Tfinc
ResolvedNone
ResolvedNone
Resolvedbrion
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
Resolved yuvipanda
Resolved yuvipanda
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
Resolvedbrion
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
Invalid yuvipanda
Resolvedbrion
ResolvedNone
Resolved yuvipanda
Resolved yuvipanda
Resolvedbrion
Resolved yuvipanda
ResolvedNone
ResolvedNone
Resolved yuvipanda
Resolvedbrion
Resolved yuvipanda
Invalidbrion
Resolved yuvipanda
Resolved yuvipanda
Resolved yuvipanda
ResolvedNone
ResolvedNone
ResolvedNone
DeclinedNone
Resolved Tfinc
Resolved yuvipanda
Resolved yuvipanda
Resolved yuvipanda
Resolved yuvipanda
ResolvedNone
ResolvedNone
Resolvedbrion
ResolvedNone
Resolved yuvipanda
InvalidNone
Resolvedbrion
Resolved yuvipanda
Resolved yuvipanda
Resolvedbrion
Resolvedbrion
Resolved yuvipanda
Resolvedbrion
Resolvedbrion

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 21 2014, 11:47 PM
bzimport set Reference to bz31702.
brion added a comment.Oct 21 2011, 6:28 PM

Anis, can you include a link to the commit that resolves this please? Thanks!

brion added a comment.Oct 21 2011, 6:41 PM

That commit has the comment "fixing nearme returned urls"; is that also a general fix for the above-noted network errors?

anis wrote:

Yes it should be. Trying disabling your network connection and launch the app.

brion added a comment.Oct 21 2011, 6:47 PM

The reason I ask is that that commit only changes the NearMeActivity and WikiItemizedOverlay Android plugin pieces, and tweaks the width of a textview. As far as I know none of these activities are in use when we start the app?

anis wrote:

It is actually an earlier commit

https://github.com/nitobi/Wikipedia/commit/eea4be11efc3d22c3981679becb29ccc03d6d665

but it works with the latest revision of master

I basically added a timeout and an error handler

brion added a comment.Oct 21 2011, 8:20 PM

Thanks. Please always point to the actual revisions which actually make changes, otherwise we can't tell what you're talking about and it makes review and maintenance a lot harder.

What's with replacing jQuery with this Zepto thing? Why is that done together with a stop button? Is that a requirement? Are there any other benefits? Please be sure to document such things when making changes!

anis wrote:

Sorry about that...

Zepto is a much lighter version of jQuery optimized for mobile. jQuery has a lot of desktop browser specific code (IE 6 specific code for instance) that we don't need for mobile. The syntax is the same. It is missing some jQuery functions but the main ones are supported. It also includes some other functions only available on webkit mobile.

https://github.com/madrobby/zepto

The stop button change is totally unrelated to Zepto. I just happened to make both changes at the same time.

I will from now on submit the commit url every time I update a ticket to RESOLVE. Apologies...