Page MenuHomePhabricator

Android app should not show a confirm bookmarks dialog
Closed, ResolvedPublic

Description

Just add the bookmark and do a quick notification at the bottom of the screen saying 'Bookmark Added'.

http://meta.wikimedia.org/wiki/File:Wiki_0004_Article_BookmarkAdded.png


Version: 1.0.0 (Android)
Severity: normal

Details

Reference
bz31705

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 21 2014, 11:48 PM
bzimport set Reference to bz31705.
bzimport added a subscriber: Unknown Object (MLST).

Pull request: https://github.com/nitobi/Wikipedia/pull/40

Commits in this branch pull in the PhoneGap-Toast plugin to allow use of Android's lightweight "Toast notifications" -- these show briefly on screen but are non-modal, and is the same as the stock Android Browser uses to tell you you've added a bookmark.

Switched adding bookmarks from a confirmation prompt to just showing you the notification; switched deleting bookmarks from an alert() prompt after confirmation and deletion into a lightweight toast notification after confirmation and deletion.

Also i18n-ify'd the related UI strings; added English versions and qqq descriptions.