The @dataProvider annotation should be a static function, make abstract LexemeFieldTestBase::getTestData static and adjust the usages (More infos at T332865).
Would be nice to rename it to LexemeFieldTestBase::provideTestData to make it named like other providers
Initial work was done in 70d1140cadad3224388685dc01b9cd9bd572b0df
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| tests: Make PHPUnit data provider static | mediawiki/extensions/WikibaseLexemeCirrusSearch | master | +28 -24 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Stalled | None | T255792 Quibble runs core:unit tests twice! | |||
| Stalled | None | T334726 Use return type `never` in Wikibase | |||
| Open | None | T232915 Red-green in PHPUnit code coverage are hard to read | |||
| Open | None | T328919 Upgrade PHPUnit in MediaWiki code to PHPUnit 10 | |||
| Open | None | T225730 Reduce runtime of MW shared gate Jenkins jobs to 5 min | |||
| Open | None | T332865 PHPUnit data providers should be simple static functions that return plain data | |||
| Resolved | Umherirrender | T337130 Make PHPUnit dataProvider LexemeFieldTestBase::getTestData static (WikibaseLexemeCirrusSearch extension) |
Change #1147868 had a related patch set uploaded (by Umherirrender; author: Umherirrender):
[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] tests: Make PHPUnit data provider static
Change #1147868 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] tests: Make PHPUnit data provider static