Page MenuHomePhabricator

Some GrowthExperiments Selenium tests failing, because the browser window is too small (it's not in fullscreen mode)
Open, LowPublic

Description

Some GrowthExperiments Selenium tests failing, because the browser window is too small (it's not in fullscreen mode).

Example failing change: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/921587

Video from the test artifacts:

The failure is at the end, and it fails because the "Publish" button is covered by the suggested edits popup. It probably would fit just fine if the browser window was using the full screen, but it's not:

cap_Homepage-saves-change-tags-for-unstructured-task-edits-made-via-VisualEditor-2023-05-20T17-30-03-747Z_00_00_14_01.jpg (1×1 px, 145 KB)

Seemingly this used to work until recently.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 921608 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/GrowthExperiments@master] Temporarily disable failing tests

https://gerrit.wikimedia.org/r/921608

The default skin was changed some hours before with 5e453406e5358ba5dd9af44b0b59c7490472add1
Maybe the full width should be default option when browser tests are run.

Oooh that makes sense, thanks.

Maybe the full width should be default option when browser tests are run.

It probably wouldn't have helped here, the browser window is so small, the full width probably looks exactly the same.

Change 921608 merged by Bartosz Dziewoński:

[mediawiki/extensions/GrowthExperiments@master] Temporarily disable failing tests

https://gerrit.wikimedia.org/r/921608

Tgr subscribed.

Moving into current sprint (-ish; we can look at it once urgent product work is done). We should probably fix the test that got disabled.