Maniphest T337148

Make PHPUnit dataProvider static in WikibaseCirrusSearch tests
Closed, ResolvedPublic
Actions

Assigned To

Lucas_Werkmeister_WMDE

Authored By

	Umherirrender
	May 20 2023, 8:28 PM

Tags

Referenced Files

None

Subscribers

Lucas_Werkmeister_WMDE

Description

The @dataProvider annotation should be a static function, check and make data provider in the extension, at least:

AllLabelsFieldTest with provideFieldData
DescriptionFieldTest with getFieldDataProvider
abstract WikibaseNumericFieldTestCase with getFieldDataProvider and its implementations in:
- SiteLinkCountFieldTest
- StatementCountFieldTest
LabelsFieldTest with getFieldDataProvider
StatementQuantityFieldTest with statementsProvider

static and adjust the usages (More infos at T332865).

Initial work was done in bd214aeaafd6b16f227b11eb2bd6348894d900c7

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Make PHPUnit dataProvider methods static	mediawiki/extensions/WikibaseCirrusSearch	master	+16 -19

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Stalled		None	T255792 Quibble runs core:unit tests twice!
		Stalled		None	T334726 Use return type `never` in Wikibase
		Open		None	T232915 Red-green in PHPUnit code coverage are hard to read
		Open		None	T328919 Upgrade PHPUnit in MediaWiki code to PHPUnit 10
		Open		None	T225730 Reduce runtime of MW shared gate Jenkins jobs to 5 min
		Open		None	T332865 PHPUnit data providers should be simple static functions that return plain data
		Resolved		None	T371467 [GENERAL] Make PHPUnit dataProvider static in Wikibase-related extensions
		Resolved		Lucas_Werkmeister_WMDE	T337148 Make PHPUnit dataProvider static in WikibaseCirrusSearch tests

Event Timeline

Umherirrender created this task.May 20 2023, 8:28 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2023, 8:28 PM

Umherirrender added a parent task: T332865: PHPUnit data providers should be simple static functions that return plain data.May 20 2023, 8:28 PM

Umherirrender updated the task description. (Show Details)May 20 2023, 8:33 PM

Lucas_Werkmeister_WMDE added a project: [DEPRECATED] wdwb-tech.May 30 2023, 11:26 AM

Umherirrender updated the task description. (Show Details)May 30 2023, 7:35 PM

Umherirrender unsubscribed.Jul 12 2023, 8:42 PM

Lucas_Werkmeister_WMDE mentioned this in T371467: [GENERAL] Make PHPUnit dataProvider static in Wikibase-related extensions.Jul 31 2024, 10:24 AM

Lucas_Werkmeister_WMDE edited parent tasks, added: T371467: [GENERAL] Make PHPUnit dataProvider static in Wikibase-related extensions; removed: T332865: PHPUnit data providers should be simple static functions that return plain data.

AudreyPenven_WMDE updated the task description. (Show Details)Nov 29 2024, 10:55 AM

karapayneWMDE added a project: [Archived]Wikidata Dev Team.Dec 2 2024, 9:26 AM

karapayneWMDE moved this task from Incoming to SEND TO OMEGA BOARD. Will land in the 'incoming' column and need to be moved to the correct location (former Unified DOT Backlog) on the [Archived]Wikidata Dev Team board.Dec 2 2024, 9:31 AM

Lucas_Werkmeister_WMDE claimed this task.Dec 2 2024, 4:42 PM

Lucas_Werkmeister_WMDE edited projects, added [Archived]Wikidata Dev Team (Wikidata.org Slice); removed [Archived]Wikidata Dev Team.

Lucas_Werkmeister_WMDE moved this task from In Task Breakdown to In Development on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.

Change #1099743 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseCirrusSearch@master] Make PHPUnit dataProvider methods static

https://gerrit.wikimedia.org/r/1099743

gerritbot added a project: Patch-For-Review.Dec 2 2024, 4:48 PM

Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task.Dec 2 2024, 4:48 PM

Lucas_Werkmeister_WMDE moved this task from In Development to Ready for Peer Review on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.

Lucas_Werkmeister_WMDE subscribed.

ArthurTaylor moved this task from Ready for Peer Review to In Peer Review on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.Dec 3 2024, 9:14 AM

ArthurTaylor moved this task from In Peer Review to Ready for Tech Verification on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.

Change #1099743 merged by jenkins-bot:

[mediawiki/extensions/WikibaseCirrusSearch@master] Make PHPUnit dataProvider methods static

https://gerrit.wikimedia.org/r/1099743

Lucas_Werkmeister_WMDE closed this task as Resolved.Dec 3 2024, 9:45 AM

Lucas_Werkmeister_WMDE claimed this task.

Lucas_Werkmeister_WMDE updated the task description. (Show Details)

Lucas_Werkmeister_WMDE moved this task from Ready for Tech Verification to Done on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.8; 2024-12-17).Dec 3 2024, 10:00 AM

Maintenance_bot removed a project: Patch-For-Review.Dec 3 2024, 10:30 AM