Maniphest T337151

Make PHPUnit dataProvider static in WikibaseLexeme tests
Closed, ResolvedPublic
Actions

Description

The @dataProvider annotation should be a static function, check and make data provider static and adjust the usages (More infos at T332865), at least:

ChangeOpLanguageTest with invalidEntityProvider
ChangeOpLemmaEditTest with invalidEntityProvider
ChangeOpLemmaRemoveTest with invalidEntityProvider
ChangeOpLexicalCategoryTest with invalidEntityProvider
LexemeContentTest with provideGetPatchedCopy
InfoActionHookHandlerTest with handleProvider
LemmaTermValidatorTest with dataProvider_validTerms and dataProvider_invalidTerms
LexemeMetaTagsCreatorTest with provideTestGetMetaTags

Initial work was done in a4cb8aede0d02711552f458ae9075bad7aa0d4dc
I60d173c12c23e563ab08badc52b86970986c9893

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Make PHPUnit dataProvider methods static	mediawiki/extensions/WikibaseLexeme	master	+23 -79

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Stalled		None	T255792 Quibble runs core:unit tests twice!
		Stalled		None	T334726 Use return type `never` in Wikibase
		Open		None	T328919 Upgrade PHPUnit in MediaWiki code to PHPUnit 10
		Open		None	T225730 Reduce runtime of MW shared gate Jenkins jobs to 5 min
		Open		None	T332865 PHPUnit data providers should be simple static functions that return plain data
		Resolved		None	T371467 [GENERAL] Make PHPUnit dataProvider static in Wikibase-related extensions
		Resolved		Lucas_Werkmeister_WMDE	T337151 Make PHPUnit dataProvider static in WikibaseLexeme tests

Event Timeline

Umherirrender created this task.May 20 2023, 9:09 PM

Umherirrender added a parent task: T332865: PHPUnit data providers should be simple static functions that return plain data.May 20 2023, 9:13 PM

Maintenance_bot added a project: Wikidata.May 20 2023, 9:29 PM

Lucas_Werkmeister_WMDE added a project: [DEPRECATED] wdwb-tech.May 30 2023, 11:27 AM

Umherirrender updated the task description. (Show Details)May 30 2023, 7:34 PM

Umherirrender unsubscribed.Jul 12 2023, 8:42 PM

Lucas_Werkmeister_WMDE mentioned this in T371467: [GENERAL] Make PHPUnit dataProvider static in Wikibase-related extensions.Jul 31 2024, 10:24 AM

Lucas_Werkmeister_WMDE edited parent tasks, added: T371467: [GENERAL] Make PHPUnit dataProvider static in Wikibase-related extensions; removed: T332865: PHPUnit data providers should be simple static functions that return plain data.

AudreyPenven_WMDE updated the task description. (Show Details)Nov 29 2024, 11:05 AM

karapayneWMDE added a project: [Archived]Wikidata Dev Team.Dec 2 2024, 9:27 AM

karapayneWMDE moved this task from Incoming to SEND TO OMEGA BOARD. Will land in the 'incoming' column and need to be moved to the correct location (former Unified DOT Backlog) on the [Archived]Wikidata Dev Team board.Dec 2 2024, 9:31 AM

Lucas_Werkmeister_WMDE claimed this task.Dec 2 2024, 4:07 PM

Lucas_Werkmeister_WMDE edited projects, added [Archived]Wikidata Dev Team (Wikidata.org Slice); removed [Archived]Wikidata Dev Team.

Lucas_Werkmeister_WMDE moved this task from In Task Breakdown to In Development on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.

Change #1099738 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Make PHPUnit dataProvider methods static

https://gerrit.wikimedia.org/r/1099738

gerritbot added a project: Patch-For-Review.Dec 2 2024, 4:17 PM

Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task.Dec 2 2024, 4:17 PM

Lucas_Werkmeister_WMDE moved this task from In Development to Ready for Peer Review on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.

Lucas_Werkmeister_WMDE subscribed.

Change #1099738 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Make PHPUnit dataProvider methods static

https://gerrit.wikimedia.org/r/1099738

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.8; 2024-12-17).Dec 3 2024, 9:00 AM

ArthurTaylor moved this task from Ready for Peer Review to Ready for Tech Verification on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.Dec 3 2024, 9:26 AM

Maintenance_bot removed a project: Patch-For-Review.Dec 3 2024, 9:30 AM

Lucas_Werkmeister_WMDE closed this task as Resolved.Dec 3 2024, 9:44 AM

Lucas_Werkmeister_WMDE claimed this task.

Lucas_Werkmeister_WMDE updated the task description. (Show Details)

Lucas_Werkmeister_WMDE moved this task from Ready for Tech Verification to Done on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.